Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure codespell, Codecov, post-release checklist discussion items for Billingegroup/DiffPy packages #170

Closed
3 tasks done
bobleesj opened this issue Oct 29, 2024 · 6 comments

Comments

@bobleesj
Copy link
Collaborator

bobleesj commented Oct 29, 2024

Add more as needed:

@bobleesj
Copy link
Collaborator Author

We are currently experimenting whether we want to implement static type checking here: diffpy/diffpy.snmf#124. More updates to be provided based on our experience.

@bobleesj
Copy link
Collaborator Author

bobleesj commented Nov 7, 2024

Also another comment for me (low priority after our packages support py 3.13) - we need to ensure our package follows PEP8 (https://peps.python.org/pep-0008/).

Some possible options:

  1. Check whether pre-commit has a hook (ideal solution)
  2. Add this to the github release issue checklist

@sbillinge
Copy link
Collaborator

Flake8 is linting for PEP8 so we are already doing that, but not applying it strictly to function/class names.

Changing variable names can break code in a non-backwards compatible way so this needs to be done carefully.

@bobleesj
Copy link
Collaborator Author

bobleesj commented Nov 8, 2024

Changing variable names can break code in a non-backwards compatible way so this needs to be done carefully.

right, should have considered this aspect more when asking to change variable names for diffpy.utils, a package affecting others. Sorry about that, I will ask for your confirmation next time.

@sbillinge
Copy link
Collaborator

Changing variable names can break code in a non-backwards compatible way so this needs to be done carefully.

right, should have considered this aspect more when asking to change variable names for diffpy.utils, a package affecting others. Sorry about that, I will ask for your confirmation next time.

no worries. this is how code gets better....people make suggestions, code gets reviewed.....

@bobleesj bobleesj changed the title Next re-cut action items for Billingegroup/DiffPy packages Configure codespell, Codecov, post-release checklist discussion items for Billingegroup/DiffPy packages Dec 16, 2024
@bobleesj
Copy link
Collaborator Author

Closing this issue - codespell, Codecov, release checklist all finalized and implemented in the current main branch of this cookiecutter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants