-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure codespell, Codecov, post-release checklist discussion items for Billingegroup/DiffPy packages #170
Comments
We are currently experimenting whether we want to implement static type checking here: diffpy/diffpy.snmf#124. More updates to be provided based on our experience. |
Also another comment for me (low priority after our packages support py 3.13) - we need to ensure our package follows PEP8 (https://peps.python.org/pep-0008/). Some possible options:
|
Flake8 is linting for PEP8 so we are already doing that, but not applying it strictly to function/class names. Changing variable names can break code in a non-backwards compatible way so this needs to be done carefully. |
right, should have considered this aspect more when asking to change variable names for diffpy.utils, a package affecting others. Sorry about that, I will ask for your confirmation next time. |
no worries. this is how code gets better....people make suggestions, code gets reviewed..... |
Closing this issue - codespell, Codecov, release checklist all finalized and implemented in the current |
Add more as needed:
The text was updated successfully, but these errors were encountered: