Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger decorations issues #976

Closed
bpringe opened this issue Jan 21, 2021 · 0 comments
Closed

Debugger decorations issues #976

bpringe opened this issue Jan 21, 2021 · 0 comments
Labels
bug Something isn't working debugger

Comments

@bpringe
Copy link
Member

bpringe commented Jan 21, 2021

Opening this to track some issues with the way debugger decorations work.

Issue 1

  1. Instrument a function
  2. In another namespace where the instrumented function is referenced, change the reference to make it no longer reference the function, and see that the decoration is not removed

decorations1

Issue 2

  1. Instrument a function
  2. In another namespace, reference the function and see that the decoration is not added

decorations2

Issue 3

  1. Instrument a function
  2. Change the function definition name and see that the references to the old function are no longer decorated, though the function definition still exists in the repl and is still instrumented
  3. Calling the old function cause the debugger to start and break in the newly named function, as if it were the old one

decorations3


I'm not sure if issue 3.3 is something that can totally be "fixed" since it's somewhat a symptom of the repl that old function definitions are left around, but maybe those references to the old function, which still exists and is instrumented, should still be decorated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working debugger
Projects
None yet
Development

No branches or pull requests

1 participant