Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jack-in prompt never showing on some Windows machines #885

Closed
PEZ opened this issue Dec 23, 2020 · 0 comments
Closed

Jack-in prompt never showing on some Windows machines #885

PEZ opened this issue Dec 23, 2020 · 0 comments
Assignees
Labels
bug Something isn't working connect jack-in

Comments

@PEZ
Copy link
Collaborator

PEZ commented Dec 23, 2020

On my Virtual Box Windows machine, jack-in doesn't work since we added the Live Share changes. The cause is that the way we use vscode.workspace.fs.stat(uri) is not the way it is recommended by the VS Code team.

This doesn't seem to affect non-Windows users, and also I see no reports of it causing problems to any Windows users either. Except me then.

The code where this is happening is fundamental, so when it hits it will cause a lot of things in Calva to stop working.

@PEZ PEZ added bug Something isn't working jack-in connect labels Dec 23, 2020
@PEZ PEZ self-assigned this Dec 23, 2020
@PEZ PEZ mentioned this issue Dec 23, 2020
21 tasks
@PEZ PEZ closed this as completed in 0d40be4 Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working connect jack-in
Projects
None yet
Development

No branches or pull requests

1 participant