Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go to definition jumps to inc instead of inc' #884

Closed
brdloush opened this issue Dec 22, 2020 · 1 comment
Closed

go to definition jumps to inc instead of inc' #884

brdloush opened this issue Dec 22, 2020 · 1 comment
Labels
bug Something isn't working parsing

Comments

@brdloush
Copy link
Contributor

Whenever inc' is used in the code editor, calva treats it as regular inc (without trailing single quote). When mouse-hovering over it, only the part before single quote is gets underlined. The popup window with documentation shows inc documentation instead of inc'. Finally, when you use Go to definition (F12), it opens source code of inc.

Interestingly, Trigger parameter hints shows correct hints for parameters of inc' 👍

@bpringe bpringe added bug Something isn't working parsing labels Dec 22, 2020
@PEZ
Copy link
Collaborator

PEZ commented Jan 3, 2021

Yes, it is a bit interesting that we get it right in some cases. 😄 The first (the failing) cases uses the quite crude API vscode has for this, which recognizes words and we then get to respond on the words it sends us. We were missing single quote as a valid word character. It is now being fixed in a PR.

The last (the working) case is using one of our own grammars for Clojure code, which ”knows” a bit more about how to scan for valid Clojure symbols.

@bpringe bpringe closed this as completed in 5a2c834 Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parsing
Projects
None yet
Development

No branches or pull requests

3 participants