Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make e2e test runner re-usable #2058

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Make e2e test runner re-usable #2058

merged 2 commits into from
Feb 2, 2023

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Feb 2, 2023

  • The e2e test launcher now takes args:
    • calva-vsix: <vsix>, if omitted the development Calva will be used
    • test-workspace: `
  • The CI pipeline now tests two workspaces
    • ./src/extension-test/e2e-test (where the test-runner also lives)
    • ./test-data/projects/e2e-sub-projects intended to run some tests with jack-in and clojure-lsp and what not where sub-projects are involved

I don't think this with several projects will scale all that well, but could come in handy for some special project structure. Maybe Polylith is worth it's own e2e testing.

What has changed?

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • [ ] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • [ ] Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
    • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
  • Created the issue I am fixing/addressing, if it was not present.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

@PEZ PEZ merged commit 751576c into dev Feb 2, 2023
@PEZ PEZ deleted the pez/e2e-tests-configurability branch February 2, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants