Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fake stream output if model doesn't support it but stream=True #61

Closed
krrishdholakia opened this issue Aug 7, 2023 · 4 comments
Closed

Comments

@krrishdholakia
Copy link
Contributor

Screenshot 2023-08-07 at 1 13 55 PM
@krrishdholakia
Copy link
Contributor Author

if somebody used us assuming we'd return a stream (generator object i believe) and we returned a dict, we'd break in code for them.

@zakhar-kogan
Copy link
Contributor

Does this need a separate model flag, e.g., supports_streaming = True, to distinguish?

@krrishdholakia
Copy link
Contributor Author

Not really - we already have a customstreamwrapper, we can just add this as default logic and send all model results there if stream=true

@krrishdholakia
Copy link
Contributor Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants