Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying module defining PrefireProvider breaks snapshot-tests generation #72

Open
EduardJelenski opened this issue Aug 29, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@EduardJelenski
Copy link

Context πŸ•΅οΈβ€β™€οΈ

Specifying module like this struct FooPreviews: ModuleA.PrefierProvider { ... }

What 🌱

I guess such specification (that can take place in multimodular projects) shouldn't affect snapshot tests generation

Proposal πŸŽ‰

I suppose Prefire parses project files and collects previews marked with PrefireProvider, if that's the case β€” then parser should use mask [space]*.PrefireProvider to avoid the issue

@BarredEwe BarredEwe added the bug Something isn't working label Aug 29, 2024
@BarredEwe
Copy link
Owner

And really, it's a bug. I was able to reproduce it like this: Prefire.PrefireProvider
I'll make a fix in the near future.

@BarredEwe BarredEwe added the good first issue Good for newcomers label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants