Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Work product] Reorder blog entry + clear exposition of code merged #1

Closed
5 tasks done
ericneiva opened this issue Aug 20, 2021 · 1 comment
Closed
5 tasks done

Comments

@ericneiva
Copy link

ericneiva commented Aug 20, 2021

Hi, @Balaje,

I have reviewed your work product blog entry.

I think it shows quite well that you have worked a lot and well these past weeks. In order to help readers find better the code you merged and the interaction with the mentors, I suggest you the following small reordering + additions:

  • Put "Pull Requests submitted" section before "Evaluating CellField on arbitrary point (Complete)"
  • Rename "Pull Requests submitted" to "New features and merged PRs"
  • In the same section: Rename "Evaluate FEFunction at arbitrary points:" to "Evaluate FEFunction at arbitrary points: (since Gridap release v.0.16.0)".
  • In the same section: Group "Fix evaluation for RT Elements: " and "Interpolation between FESpace:" into "Interpolation between FESpaces: (since Gridap release v.0.16.4)"
  • The link to PR#523 could be this one, i.e. the first where you are mentioned.
@ericneiva
Copy link
Author

Good, @Balaje, I've seen you've applied all these changes.

The only thing I spotted is a missing closing parenthesis in "(since Gridap release v.0.16.4".

Closing the issue, anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant