Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeSpy setTimeout doesn't support additional parameters #81

Closed
ghost opened this issue Nov 6, 2017 · 3 comments
Closed

TimeSpy setTimeout doesn't support additional parameters #81

ghost opened this issue Nov 6, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Nov 6, 2017

The additional parameters that get passed to the timeout function are included in the setTimeout implementation in TimeSpy. My application which uses these parameters crashed when they weren't present.

I was able to work around the problem using a scoped variable, but thought I would raise it as an issue.

@sebavan
Copy link
Member

sebavan commented Nov 6, 2017

Thanks for reporting it, i will fix it ASAP. I completely missed this case.

@sebavan sebavan self-assigned this Nov 6, 2017
@sebavan sebavan added the bug label Nov 6, 2017
@sebavan sebavan added this to the Version 1.0 milestone Nov 6, 2017
@sebavan sebavan closed this as completed in d6258d9 Nov 7, 2017
@sebavan
Copy link
Member

sebavan commented Nov 7, 2017

@clevea , The previous commit fixed the issue, you can sideload the extension for the time being I will release the new version by end of month.

@anlumo
Copy link

anlumo commented Dec 11, 2017

Just stumbled upon this issue… took me an hour to locate Spector as the culprit, since the exception is just in a VM12535 minified file.

Please update the store version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants