Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better stacktraces support? #47

Closed
makc opened this issue Jul 19, 2017 · 4 comments
Closed

better stacktraces support? #47

makc opened this issue Jul 19, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@makc
Copy link

makc commented Jul 19, 2017

more like feature request, I guess - in firefox there are no stack traces, in chrome stack traces are present but not clickable.

@makc
Copy link
Author

makc commented Jul 19, 2017

the problem with current code is the regexp /^\s*[A-Za-z0-9-_$]+(/ - it matches chrome format

window.onload (https://fiddle.jshell.net/_display/:45:11)

but does not match firefox format

window.onload@https://fiddle.jshell.net/_display/:45:11

the only point in having this check would be to skip 1st line in chrome, I guess?

p.s. you dont have to throw the error, just do let err = new Error;

@sebavan
Copy link
Member

sebavan commented Jul 20, 2017

Cool Thanks for the feedback, I ll fix in the next version.

@sebavan sebavan added the bug label Jul 20, 2017
@sebavan sebavan self-assigned this Jul 20, 2017
@sebavan sebavan added this to the Version 0.9 milestone Jul 20, 2017
@makc
Copy link
Author

makc commented Jul 20, 2017

actually I was wrong, the chrome case is handled by " at " case. Idk what does that regexp match?

@sebavan
Copy link
Member

sebavan commented Jul 25, 2017

I ll double check it on more browsers, It was probably matching with old versions. This will never be safe anyway :-) but there are no available APIs in js for this.

@sebavan sebavan closed this as completed in 8e5053f Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants