Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on SPIRV-Cross for OpenGL scenarios #300

Closed
syntheticmagus opened this issue Jun 18, 2020 · 1 comment
Closed

Remove dependency on SPIRV-Cross for OpenGL scenarios #300

syntheticmagus opened this issue Jun 18, 2020 · 1 comment

Comments

@syntheticmagus
Copy link
Contributor

syntheticmagus commented Jun 18, 2020

When the target rendering path is OpenGL, SPIRV-Cross should not actually be necessary because glslang should be sufficient to do all our required conversions on its own. Note that to make this change, all of the logic in NativeEngine::CreateProgram that depends on SPIRV-Cross types will need to be rewritten to use glslang instead; that logic should probably also be pulled out of NativeEngine, too. This is therefore expected to be a fairly large change that will affect behavior in every rendering path because it will change how the bgfx shader representations are created.

@bghgary
Copy link
Contributor

bghgary commented Apr 21, 2022

Reopen if we have a need to make this work.

@bghgary bghgary closed this as completed Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants