Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make adding sensors easier #449

Open
mattpow35 opened this issue Mar 15, 2021 · 0 comments
Open

Make adding sensors easier #449

mattpow35 opened this issue Mar 15, 2021 · 0 comments

Comments

@mattpow35
Copy link
Contributor

mattpow35 commented Mar 15, 2021

Adding sensors to agents programmatically should be easier for users. Right now you would have to create a sensor definition and pass it to env.agents['name'].add_sensors(SensorDefinition(params...)). This isn't too complicated, but is unintuitive for users. I think it might be better to avoid having the user see the sensor definition, and instead provide a simple function that takes all the params for a sensor def rather than the def itself and adds the sensor under the skin. Adding sensors (which includes all tasks) is common and should be simple and intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant