Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TurtleAgent movement is inconsistent between Windows and Linux #336

Open
jaydenmilne opened this issue Nov 2, 2019 · 3 comments
Open

TurtleAgent movement is inconsistent between Windows and Linux #336

jaydenmilne opened this issue Nov 2, 2019 · 3 comments
Labels

Comments

@jaydenmilne
Copy link
Contributor

Describe the bug
test_turtleagent_movement is broken on Linux since the turtle agent moves differently. @daniekpo has made a valiant effort to identify the issue.

It appears to be related somehow to the handling of floating point numbers and rounding between Linux and Windows.

The test has been marked as broken.

To Reproduce
Run test_turtleagent_movement. On Windows (the platform it was written on) the test passes; Linux fails.

@jaydenmilne jaydenmilne added the bug label Nov 2, 2019
@jaydenmilne
Copy link
Contributor Author

@daniekpo could you describe what you found so we can have it written down before we all forget?

We've decided this isn't worth fixing.

@daniekpo
Copy link
Contributor

I collected the agent's location and rotation data from both Windows and Linux. I compared the data when the agent had not moved yet and they seemed pretty equal. I compared the data after moving the agent in a straight line and noticed very minor differences (maybe around e-6) but the differences increased over time.

I suspect it had something to do with floating-point rounding errors that kept accumulating. It makes sense since we kept reusing the location and rotation to calculate the next location and rotation so the cumulative differences eventually amounted to the agent not reaching its target destination on Linux. That's my theory for now at least.

@vinhowe
Copy link
Member

vinhowe commented Apr 29, 2021

With #441, we finally have consistency: this test is failing on both Linux and Windows now. We will need to revisit this once it becomes a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants