This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Create story promo list component #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisHdz
requested review from
jamesbhobbs,
dr3,
chris-hinds,
jamesdonoh,
j-pendlebury,
pjlee11 and
sareh
as code owners
dr3
reviewed
Apr 30, 2019
packages/components/psammead-story-promo-list/src/index.stories.jsx
Outdated
Show resolved
Hide resolved
dr3
suggested changes
Apr 30, 2019
dr3
reviewed
Apr 30, 2019
dr3
reviewed
Apr 30, 2019
dr3
reviewed
Apr 30, 2019
packages/components/psammead-story-promo-list/testHelpers/fixtureData.js
Show resolved
Hide resolved
dr3
suggested changes
May 1, 2019
dr3
suggested changes
May 2, 2019
packages/components/psammead-story-promo-list/testHelpers/fixtureData.js
Outdated
Show resolved
Hide resolved
|
We might want to tweak our use of English slightly... "This component is currently tagged as alpha and is not suitable for production use. Following the passing of an accessibility review this component will be marked as ready for production and the alpha tag removed." |
dr3
previously approved these changes
May 8, 2019
There was a problem hiding this comment.
LGTM, great work :P
Weve never published anything as alpha before, lets hope my publishing script works as expected :D
ghost
reviewed
May 9, 2019
Co-Authored-By: sadickisaac <48688870+sadickisaac@users.noreply.github.com>
dr3
approved these changes
May 9, 2019
j-pendlebury
approved these changes
May 9, 2019
ghost
approved these changes
May 9, 2019
|
LGTM, a11y to be conducted once full component is delivered |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #477
Overall change:
Implement an unordered list and a list item component with no styling except a separator line to be used with
StoryPromos.Code changes:
StoryPromoUlcomponentStoryPromoLicomponent