This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Move to using Rems for breakpoints #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sareh
reviewed
Mar 18, 2019
sareh
reviewed
Mar 18, 2019
Co-Authored-By: dr3 <drew.mcmillan@bbc.co.uk>
|
We should ensure we add notes for testers to link this work in with Simorgh so they can do browser regression. Here is the browser support for rems https://caniuse.com/#feat=rem |
|
Done @sareh :) |
sareh
approved these changes
Mar 18, 2019
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part-resolves #361
Overall change: Move to using Rems for breakpoints so that the width of a component isnt influenced by the font size of its container
Code changes:
Testing:
This can be tested by linking the gel foundations component to simorgh and then using ngrok and browserstack to do a visual regression on different browsers, taking support https://caniuse.com/#feat=rem into consideration.