From 4b74b0bd47fa36be605b033ad96e6e31060afa33 Mon Sep 17 00:00:00 2001 From: Rebecca McGinn Date: Wed, 4 Mar 2020 09:06:27 +0000 Subject: [PATCH 1/2] Removing isRequired from mediaInfo prop --- packages/components/psammead-media-player/src/index.jsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/components/psammead-media-player/src/index.jsx b/packages/components/psammead-media-player/src/index.jsx index beb4a2ae26..223c593316 100644 --- a/packages/components/psammead-media-player/src/index.jsx +++ b/packages/components/psammead-media-player/src/index.jsx @@ -119,13 +119,13 @@ CanonicalMediaPlayer.propTypes = { noJsClassName: string, noJsMessage: string.isRequired, mediaInfo: shape({ - title: string.isRequired, + title: string, datetime: string, duration: string, durationSpoken: string, type: oneOf(['video', 'audio']), guidanceMessage: string, - }).isRequired, + }), }; CanonicalMediaPlayer.defaultProps = { @@ -135,6 +135,7 @@ CanonicalMediaPlayer.defaultProps = { placeholderSrc: null, placeholderSrcset: null, noJsClassName: null, + mediaInfo: {}, }; MediaMessage.propTypes = { From 3f3d08f85b1fa1b7f7d601612973d3f4b642c66a Mon Sep 17 00:00:00 2001 From: Rebecca McGinn Date: Wed, 4 Mar 2020 09:24:33 +0000 Subject: [PATCH 2/2] Updating changelog and version number for psammead-media-player --- packages/components/psammead-media-player/CHANGELOG.md | 1 + packages/components/psammead-media-player/package-lock.json | 2 +- packages/components/psammead-media-player/package.json | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/components/psammead-media-player/CHANGELOG.md b/packages/components/psammead-media-player/CHANGELOG.md index 6f0540fc03..7cd0937612 100644 --- a/packages/components/psammead-media-player/CHANGELOG.md +++ b/packages/components/psammead-media-player/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | | ------------- | ---------------------------------------------------------------------------------------------------------------------------- | +| 2.7.4 | [PR#3205](https://github.com/bbc/psammead/pull/3205) Removed isRequired from mediaInfo prop as not always required | | 2.7.3 | [PR#3151](https://github.com/bbc/psammead/pull/3151) Talos - Bump Dependencies - @bbc/psammead-play-button | | 2.7.2 | [PR#3113](https://github.com/bbc/psammead/pull/3113) Added bottom margin padding for live radio audio player | | 2.7.1 | [PR#3060](https://github.com/bbc/psammead/pull/3060) Refactored Message component to display message for Expired AV Stream | diff --git a/packages/components/psammead-media-player/package-lock.json b/packages/components/psammead-media-player/package-lock.json index 22b8df89e0..3c9e2d953e 100644 --- a/packages/components/psammead-media-player/package-lock.json +++ b/packages/components/psammead-media-player/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-media-player", - "version": "2.7.3", + "version": "2.7.4", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/components/psammead-media-player/package.json b/packages/components/psammead-media-player/package.json index a406225810..db84deb4c6 100644 --- a/packages/components/psammead-media-player/package.json +++ b/packages/components/psammead-media-player/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-media-player", - "version": "2.7.3", + "version": "2.7.4", "description": "Provides a media player with optional placeholder", "main": "dist/index.js", "module": "esm/index.js",