From ac0b9c388221a992b064f14c5531b04db619cce4 Mon Sep 17 00:00:00 2001 From: Fahad Khan Date: Tue, 22 Oct 2019 14:55:23 +0100 Subject: [PATCH 1/2] convert default export to named export and edit imports --- packages/components/psammead-image/src/index.amp.stories.jsx | 2 +- packages/components/psammead-image/src/index.stories.jsx | 2 +- .../components/psammead-image/src/testHelpers/stories.jsx | 4 +--- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/components/psammead-image/src/index.amp.stories.jsx b/packages/components/psammead-image/src/index.amp.stories.jsx index c430a81f7b..23c44c4fb3 100644 --- a/packages/components/psammead-image/src/index.amp.stories.jsx +++ b/packages/components/psammead-image/src/index.amp.stories.jsx @@ -1,5 +1,5 @@ import AmpImg from './index.amp'; -import stories from './testHelpers/stories'; +import { stories } from './testHelpers/stories'; import { ampDecorator } from '../../../../.storybook/config'; const additionalProps = { diff --git a/packages/components/psammead-image/src/index.stories.jsx b/packages/components/psammead-image/src/index.stories.jsx index 64b9bc0e3c..e8932bfbf7 100644 --- a/packages/components/psammead-image/src/index.stories.jsx +++ b/packages/components/psammead-image/src/index.stories.jsx @@ -1,7 +1,7 @@ import React from 'react'; import { withKnobs } from '@storybook/addon-knobs'; import { Img } from '.'; -import stories, { getProps } from './testHelpers/stories'; +import { stories, getProps } from './testHelpers/stories'; import { landscape } from './testHelpers/fixtureData'; import notes from '../README.md'; diff --git a/packages/components/psammead-image/src/testHelpers/stories.jsx b/packages/components/psammead-image/src/testHelpers/stories.jsx index 4ca9ccd79f..026d2a66e6 100644 --- a/packages/components/psammead-image/src/testHelpers/stories.jsx +++ b/packages/components/psammead-image/src/testHelpers/stories.jsx @@ -18,7 +18,7 @@ export function getProps(image, includeHeight, type) { return props; } -const stories = ( +export const stories = ( Component, title, includeHeight = false, @@ -79,5 +79,3 @@ const stories = ( ), { notes }, ); - -export default stories; From 8064d77d5744d7f360279671d2b0f96cbb2c16f2 Mon Sep 17 00:00:00 2001 From: Fahad Khan Date: Tue, 22 Oct 2019 16:30:32 +0100 Subject: [PATCH 2/2] bumping --- packages/components/psammead-image/CHANGELOG.md | 1 + packages/components/psammead-image/package-lock.json | 2 +- packages/components/psammead-image/package.json | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/components/psammead-image/CHANGELOG.md b/packages/components/psammead-image/CHANGELOG.md index 57079e46e2..9f95a83edf 100644 --- a/packages/components/psammead-image/CHANGELOG.md +++ b/packages/components/psammead-image/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | |---------|-------------| +| 1.2.3 | [PR#2460](https://github.com/bbc/psammead/pull/2460) Fix Storybook console errors | | 1.2.2 | [PR#1942](https://github.com/bbc/psammead/pull/1942) Talos - Bump React to 16.9.0 | | 1.2.1 | [PR#1803](https://github.com/bbc/psammead/pull/1803/) Patches broken links on badges in documentation | | 1.2.0 | [PR#1794](https://github.com/bbc/psammead/pull/1794) Add david dependency badges | diff --git a/packages/components/psammead-image/package-lock.json b/packages/components/psammead-image/package-lock.json index 7c157fa4bd..e58230f0e8 100644 --- a/packages/components/psammead-image/package-lock.json +++ b/packages/components/psammead-image/package-lock.json @@ -1,5 +1,5 @@ { "name": "@bbc/psammead-image", - "version": "1.2.2", + "version": "1.2.3", "lockfileVersion": 1 } diff --git a/packages/components/psammead-image/package.json b/packages/components/psammead-image/package.json index eb37cbec8d..79657c1fd2 100644 --- a/packages/components/psammead-image/package.json +++ b/packages/components/psammead-image/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-image", - "version": "1.2.2", + "version": "1.2.3", "main": "dist/index.js", "module": "esm/index.js", "sideEffects": false,