From 6657ad1ca213a209d1bb0b86af9ff4da24e73692 Mon Sep 17 00:00:00 2001 From: radiocontrolled Date: Mon, 17 Dec 2018 14:15:15 +0000 Subject: [PATCH 01/19] WIP --- .../__snapshots__/index.test.jsx.snap | 13 +++++++++++++ packages/components/psammead-figure/src/index.jsx | 10 ++++++++++ .../components/psammead-figure/src/index.test.jsx | 7 +++++++ 3 files changed, 30 insertions(+) create mode 100644 packages/components/psammead-figure/__snapshots__/index.test.jsx.snap create mode 100644 packages/components/psammead-figure/src/index.jsx create mode 100644 packages/components/psammead-figure/src/index.test.jsx diff --git a/packages/components/psammead-figure/__snapshots__/index.test.jsx.snap b/packages/components/psammead-figure/__snapshots__/index.test.jsx.snap new file mode 100644 index 0000000000..95455aac6c --- /dev/null +++ b/packages/components/psammead-figure/__snapshots__/index.test.jsx.snap @@ -0,0 +1,13 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[`Figure should render correctly 1`] = ` +.c0 { + margin: 0; + padding-bottom: 1rem; + width: 100%; +} + +
+`; diff --git a/packages/components/psammead-figure/src/index.jsx b/packages/components/psammead-figure/src/index.jsx new file mode 100644 index 0000000000..c9c4346213 --- /dev/null +++ b/packages/components/psammead-figure/src/index.jsx @@ -0,0 +1,10 @@ +import styled from 'styled-components'; +import { GEL_SPACING_DBL } from '../../lib/constants/styles'; + +const Figure = styled.figure` + margin: 0; + padding-bottom: ${GEL_SPACING_DBL}; + width: 100%; +`; + +export default Figure; diff --git a/packages/components/psammead-figure/src/index.test.jsx b/packages/components/psammead-figure/src/index.test.jsx new file mode 100644 index 0000000000..f7c049b466 --- /dev/null +++ b/packages/components/psammead-figure/src/index.test.jsx @@ -0,0 +1,7 @@ +import React from 'react'; +import { shouldMatchSnapshot } from '../../helpers/tests/testHelpers'; +import Figure from '.'; + +describe('Figure', () => { + shouldMatchSnapshot('should render correctly',
); +}); From 6104144169cc21e87f89327644ab03bb4909ae37 Mon Sep 17 00:00:00 2001 From: radiocontrolled Date: Mon, 17 Dec 2018 15:31:25 +0000 Subject: [PATCH 02/19] figure component and merge latest --- .../psammead-brand/package-lock.json | 4 +- .../psammead-caption/package-lock.json | 4 +- .../psammead-copyright/package-lock.json | 4 +- .../components/psammead-figure/CHANGELOG.md | 5 + packages/components/psammead-figure/README.md | 19 + .../psammead-figure/package-lock.json | 399 ++++++++++++++++++ .../components/psammead-figure/package.json | 33 ++ .../__snapshots__/index.test.jsx.snap | 1 - .../components/psammead-figure/src/index.jsx | 2 +- .../psammead-figure/src/index.test.jsx | 2 +- .../psammead-headings/package-lock.json | 4 +- .../psammead-paragraph/package-lock.json | 4 +- .../psammead-sitewide-links/package-lock.json | 4 +- .../package-lock.json | 4 +- .../package-lock.json | 4 +- 15 files changed, 474 insertions(+), 19 deletions(-) create mode 100644 packages/components/psammead-figure/CHANGELOG.md create mode 100644 packages/components/psammead-figure/README.md create mode 100644 packages/components/psammead-figure/package-lock.json create mode 100644 packages/components/psammead-figure/package.json rename packages/components/psammead-figure/{ => src}/__snapshots__/index.test.jsx.snap (86%) diff --git a/packages/components/psammead-brand/package-lock.json b/packages/components/psammead-brand/package-lock.json index f654a54c38..fe67ffc959 100644 --- a/packages/components/psammead-brand/package-lock.json +++ b/packages/components/psammead-brand/package-lock.json @@ -91,12 +91,12 @@ }, "babel-plugin-syntax-jsx": { "version": "6.18.0", - "resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" }, "core-js": { "version": "1.2.7", - "resolved": "https://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" }, "css": { diff --git a/packages/components/psammead-caption/package-lock.json b/packages/components/psammead-caption/package-lock.json index 6362c1dc94..441aa2306b 100644 --- a/packages/components/psammead-caption/package-lock.json +++ b/packages/components/psammead-caption/package-lock.json @@ -111,12 +111,12 @@ }, "babel-plugin-syntax-jsx": { "version": "6.18.0", - "resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" }, "core-js": { "version": "1.2.7", - "resolved": "https://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" }, "css": { diff --git a/packages/components/psammead-copyright/package-lock.json b/packages/components/psammead-copyright/package-lock.json index 8793d9f6d8..815b411ab3 100644 --- a/packages/components/psammead-copyright/package-lock.json +++ b/packages/components/psammead-copyright/package-lock.json @@ -92,12 +92,12 @@ }, "babel-plugin-syntax-jsx": { "version": "6.18.0", - "resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" }, "core-js": { "version": "1.2.7", - "resolved": "https://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" }, "css": { diff --git a/packages/components/psammead-figure/CHANGELOG.md b/packages/components/psammead-figure/CHANGELOG.md new file mode 100644 index 0000000000..041110c498 --- /dev/null +++ b/packages/components/psammead-figure/CHANGELOG.md @@ -0,0 +1,5 @@ +# Psammead Figure Changelog + +| Version | Description | +|---------|-------------| +| 0.1.0 | [PR#220](https://github.com/BBC-News/psammead/pull/220) Create initial package with Figure component pulled in from [Simorgh](https://github.com/BBC-News/simorgh). | diff --git a/packages/components/psammead-figure/README.md b/packages/components/psammead-figure/README.md new file mode 100644 index 0000000000..5986cbe0ae --- /dev/null +++ b/packages/components/psammead-figure/README.md @@ -0,0 +1,19 @@ +# psammead-figure · [![GitHub license](https://img.shields.io/badge/license-Apache%202.0-blue.svg)](https://github.com/BBC-News/psammead/blob/latest/LICENSE) [![npm version](https://img.shields.io/npm/v/@bbc/psammead-figure.svg)](https://www.npmjs.com/package/@bbc/psammead-figure) [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)](https://github.com/BBC-News/psammead/blob/latest/CONTRIBUTING.md) + +## Description + +## When to use this component + +## Accessibility notes + +## Contributing + +Psammead is completely open source. We are grateful for any contributions, whether they be new components, bug fixes or general improvements. Please see our primary contributing guide which can be found at [the root of the Psammead respository](https://github.com/BBC-News/psammead/blob/latest/CONTRIBUTING.md). + +### [Code of Conduct](https://github.com/BBC-News/psammead/blob/latest/CODE_OF_CONDUCT.md) + +We welcome feedback and help on this work. By participating in this project, you agree to abide by the [code of conduct](https://github.com/BBC-News/psammead/blob/latest/CODE_OF_CONDUCT.md). Please take a moment to read it. + +### License + +Psammead is [Apache 2.0 licensed](https://github.com/BBC-News/psammead/blob/latest/LICENSE). diff --git a/packages/components/psammead-figure/package-lock.json b/packages/components/psammead-figure/package-lock.json new file mode 100644 index 0000000000..4889a9a142 --- /dev/null +++ b/packages/components/psammead-figure/package-lock.json @@ -0,0 +1,399 @@ +{ + "name": "@bbc/psammead-figure", + "version": "0.1.3", + "lockfileVersion": 1, + "requires": true, + "dependencies": { + "@babel/helper-annotate-as-pure": { + "version": "7.0.0", + "resolved": "https://registry.npmjs.org/@babel/helper-annotate-as-pure/-/helper-annotate-as-pure-7.0.0.tgz", + "integrity": "sha512-3UYcJUj9kvSLbLbUIfQTqzcy5VX7GRZ/CCDrnOaZorFFM01aXp1+GJwuFGV4NDDoAS+mOUyHcO6UD/RfqOks3Q==", + "requires": { + "@babel/types": "^7.0.0" + } + }, + "@babel/helper-module-imports": { + "version": "7.0.0", + "resolved": "https://registry.npmjs.org/@babel/helper-module-imports/-/helper-module-imports-7.0.0.tgz", + "integrity": "sha512-aP/hlLq01DWNEiDg4Jn23i+CXxW/owM4WpDLFUbpjxe4NS3BhLVZQ5i7E0ZrxuQ/vwekIeciyamgB1UIYxxM6A==", + "requires": { + "@babel/types": "^7.0.0" + } + }, + "@babel/types": { + "version": "7.2.2", + "resolved": "https://registry.npmjs.org/@babel/types/-/types-7.2.2.tgz", + "integrity": "sha512-fKCuD6UFUMkR541eDWL+2ih/xFZBXPOg/7EQFeTluMDebfqR4jrpaCjLhkWlQS4hT6nRa2PMEgXKbRB5/H2fpg==", + "requires": { + "esutils": "^2.0.2", + "lodash": "^4.17.10", + "to-fast-properties": "^2.0.0" + } + }, + "@bbc/gel-constants": { + "version": "0.1.2", + "resolved": "https://registry.npmjs.org/@bbc/gel-constants/-/gel-constants-0.1.2.tgz", + "integrity": "sha512-QNCSNe9PasApNIm9cira3pbk5y3CrYtlm5jukLRUo70O5IXMYQw9xaaMbB083Y5qZzP//3UeMjU94S1ZwsHExg==" + }, + "@bbc/gel-foundations-styled-components": { + "version": "0.1.1", + "resolved": "https://registry.npmjs.org/@bbc/gel-foundations-styled-components/-/gel-foundations-styled-components-0.1.1.tgz", + "integrity": "sha512-jzfv2L7hs+0rEyk6HjFIJ7sQIP8dqddCbBJov2GaWVyA+OEJLF6D69U0o3mgjPh677XZeTb7swCa8rhykSlnuQ==", + "requires": { + "@bbc/gel-constants": "^0.1.1", + "styled-components": "^4.1.1" + } + }, + "@bbc/psammead-styles": { + "version": "0.1.4", + "resolved": "https://registry.npmjs.org/@bbc/psammead-styles/-/psammead-styles-0.1.4.tgz", + "integrity": "sha512-lrt2SjpDQqUpGIONOgeo5rl9Y9pZfKfQOdkg6fr4xOd4YxN0wdlzhlMz6TinmOSK7S9r4cKY+H0HgEDNOqUmIg==" + }, + "@bbc/psammead-test-helpers": { + "version": "0.1.0", + "resolved": "https://registry.npmjs.org/@bbc/psammead-test-helpers/-/psammead-test-helpers-0.1.0.tgz", + "integrity": "sha512-k8wbEq1MmVY3rm5gTXHeMLlTTNDLywJwsFxMdXk6iSpeeuft+VT8n65RBlQs5KzSM1RH7q8kbZEyph8wz/houA==", + "dev": true, + "requires": { + "jest-styled-components": "^6.3.1", + "react-test-renderer": "^16.6.3" + } + }, + "@emotion/is-prop-valid": { + "version": "0.7.3", + "resolved": "https://registry.npmjs.org/@emotion/is-prop-valid/-/is-prop-valid-0.7.3.tgz", + "integrity": "sha512-uxJqm/sqwXw3YPA5GXX365OBcJGFtxUVkB6WyezqFHlNe9jqUWH5ur2O2M8dGBz61kn1g3ZBlzUunFQXQIClhA==", + "requires": { + "@emotion/memoize": "0.7.1" + } + }, + "@emotion/memoize": { + "version": "0.7.1", + "resolved": "https://registry.npmjs.org/@emotion/memoize/-/memoize-0.7.1.tgz", + "integrity": "sha512-Qv4LTqO11jepd5Qmlp3M1YEjBumoTHcHFdgPTQ+sFlIL5myi/7xu/POwP7IRu6odBdmLXdtIs1D6TuW6kbwbbg==" + }, + "@emotion/unitless": { + "version": "0.7.3", + "resolved": "https://registry.npmjs.org/@emotion/unitless/-/unitless-0.7.3.tgz", + "integrity": "sha512-4zAPlpDEh2VwXswwr/t8xGNDGg8RQiPxtxZ3qQEXyQsBV39ptTdESCjuBvGze1nLMVrxmTIKmnO/nAV8Tqjjzg==" + }, + "asap": { + "version": "2.0.6", + "resolved": "https://registry.npmjs.org/asap/-/asap-2.0.6.tgz", + "integrity": "sha1-5QNHYR1+aQlDIIu9r+vLwvuGbUY=" + }, + "atob": { + "version": "2.1.2", + "resolved": "https://registry.npmjs.org/atob/-/atob-2.1.2.tgz", + "integrity": "sha512-Wm6ukoaOGJi/73p/cl2GvLjTI5JM1k/O14isD73YML8StrH/7/lRFgmg8nICZgD3bZZvjwCGxtMOD3wWNAu8cg==", + "dev": true + }, + "babel-plugin-styled-components": { + "version": "1.10.0", + "resolved": "https://registry.npmjs.org/babel-plugin-styled-components/-/babel-plugin-styled-components-1.10.0.tgz", + "integrity": "sha512-sQVKG8irFXx14ZfaK1bBePirfkacl3j8nZwSZK+ZjsbnadRHKQTbhXbe/RB1vT6Vgkz45E+V95LBq4KqdhZUNw==", + "requires": { + "@babel/helper-annotate-as-pure": "^7.0.0", + "@babel/helper-module-imports": "^7.0.0", + "babel-plugin-syntax-jsx": "^6.18.0", + "lodash": "^4.17.10" + } + }, + "babel-plugin-syntax-jsx": { + "version": "6.18.0", + "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" + }, + "core-js": { + "version": "1.2.7", + "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" + }, + "css": { + "version": "2.2.4", + "resolved": "https://registry.npmjs.org/css/-/css-2.2.4.tgz", + "integrity": "sha512-oUnjmWpy0niI3x/mPL8dVEI1l7MnG3+HHyRPHf+YFSbK+svOhXpmSOcDURUh2aOCgl2grzrOPt1nHLuCVFULLw==", + "dev": true, + "requires": { + "inherits": "^2.0.3", + "source-map": "^0.6.1", + "source-map-resolve": "^0.5.2", + "urix": "^0.1.0" + } + }, + "css-color-keywords": { + "version": "1.0.0", + "resolved": "https://registry.npmjs.org/css-color-keywords/-/css-color-keywords-1.0.0.tgz", + "integrity": "sha1-/qJhbcZ2spYmhrOvjb2+GAskTgU=" + }, + "css-to-react-native": { + "version": "2.2.2", + "resolved": "https://registry.npmjs.org/css-to-react-native/-/css-to-react-native-2.2.2.tgz", + "integrity": "sha512-w99Fzop1FO8XKm0VpbQp3y5mnTnaS+rtCvS+ylSEOK76YXO5zoHQx/QMB1N54Cp+Ya9jB9922EHrh14ld4xmmw==", + "requires": { + "css-color-keywords": "^1.0.0", + "fbjs": "^0.8.5", + "postcss-value-parser": "^3.3.0" + } + }, + "decode-uri-component": { + "version": "0.2.0", + "resolved": "https://registry.npmjs.org/decode-uri-component/-/decode-uri-component-0.2.0.tgz", + "integrity": "sha1-6zkTMzRYd1y4TNGh+uBiEGu4dUU=", + "dev": true + }, + "encoding": { + "version": "0.1.12", + "resolved": "https://registry.npmjs.org/encoding/-/encoding-0.1.12.tgz", + "integrity": "sha1-U4tm8+5izRq1HsMjgp0flIDHS+s=", + "requires": { + "iconv-lite": "~0.4.13" + } + }, + "esutils": { + "version": "2.0.2", + "resolved": "https://registry.npmjs.org/esutils/-/esutils-2.0.2.tgz", + "integrity": "sha1-Cr9PHKpbyx96nYrMbepPqqBLrJs=" + }, + "fbjs": { + "version": "0.8.17", + "resolved": "https://registry.npmjs.org/fbjs/-/fbjs-0.8.17.tgz", + "integrity": "sha1-xNWY6taUkRJlPWWIsBpc3Nn5D90=", + "requires": { + "core-js": "^1.0.0", + "isomorphic-fetch": "^2.1.1", + "loose-envify": "^1.0.0", + "object-assign": "^4.1.0", + "promise": "^7.1.1", + "setimmediate": "^1.0.5", + "ua-parser-js": "^0.7.18" + } + }, + "has-flag": { + "version": "3.0.0", + "resolved": "https://registry.npmjs.org/has-flag/-/has-flag-3.0.0.tgz", + "integrity": "sha1-tdRU3CGZriJWmfNGfloH87lVuv0=" + }, + "iconv-lite": { + "version": "0.4.24", + "resolved": "https://registry.npmjs.org/iconv-lite/-/iconv-lite-0.4.24.tgz", + "integrity": "sha512-v3MXnZAcvnywkTUEZomIActle7RXXeedOR31wwl7VlyoXO4Qi9arvSenNQWne1TcRwhCL1HwLI21bEqdpj8/rA==", + "requires": { + "safer-buffer": ">= 2.1.2 < 3" + } + }, + "inherits": { + "version": "2.0.3", + "resolved": "https://registry.npmjs.org/inherits/-/inherits-2.0.3.tgz", + "integrity": "sha1-Yzwsg+PaQqUC9SRmAiSA9CCCYd4=", + "dev": true + }, + "is-stream": { + "version": "1.1.0", + "resolved": "https://registry.npmjs.org/is-stream/-/is-stream-1.1.0.tgz", + "integrity": "sha1-EtSj3U5o4Lec6428hBc66A2RykQ=" + }, + "isomorphic-fetch": { + "version": "2.2.1", + "resolved": "https://registry.npmjs.org/isomorphic-fetch/-/isomorphic-fetch-2.2.1.tgz", + "integrity": "sha1-YRrhrPFPXoH3KVB0coGf6XM1WKk=", + "requires": { + "node-fetch": "^1.0.1", + "whatwg-fetch": ">=0.10.0" + } + }, + "jest-styled-components": { + "version": "6.3.1", + "resolved": "https://registry.npmjs.org/jest-styled-components/-/jest-styled-components-6.3.1.tgz", + "integrity": "sha512-zie3ajvJbwlbHCAq8/Bv5jdbcYCz0ZMRNNX6adL7wSRpkCVPQtiJigv1140JN1ZOJIODPn8VKrjeFCN+jlPa7w==", + "dev": true, + "requires": { + "css": "^2.2.4" + } + }, + "js-tokens": { + "version": "4.0.0", + "resolved": "https://registry.npmjs.org/js-tokens/-/js-tokens-4.0.0.tgz", + "integrity": "sha512-RdJUflcE3cUzKiMqQgsCu06FPu9UdIJO0beYbPhHN4k6apgJtifcoCtT9bcxOpYBtpD2kCM6Sbzg4CausW/PKQ==" + }, + "lodash": { + "version": "4.17.11", + "resolved": "https://registry.npmjs.org/lodash/-/lodash-4.17.11.tgz", + "integrity": "sha512-cQKh8igo5QUhZ7lg38DYWAxMvjSAKG0A8wGSVimP07SIUEK2UO+arSRKbRZWtelMtN5V0Hkwh5ryOto/SshYIg==" + }, + "loose-envify": { + "version": "1.4.0", + "resolved": "https://registry.npmjs.org/loose-envify/-/loose-envify-1.4.0.tgz", + "integrity": "sha512-lyuxPGr/Wfhrlem2CL/UcnUc1zcqKAImBDzukY7Y5F/yQiNdko6+fRLevlw1HgMySw7f611UIY408EtxRSoK3Q==", + "requires": { + "js-tokens": "^3.0.0 || ^4.0.0" + } + }, + "memoize-one": { + "version": "4.0.3", + "resolved": "https://registry.npmjs.org/memoize-one/-/memoize-one-4.0.3.tgz", + "integrity": "sha512-QmpUu4KqDmX0plH4u+tf0riMc1KHE1+lw95cMrLlXQAFOx/xnBtwhZ52XJxd9X2O6kwKBqX32kmhbhlobD0cuw==" + }, + "node-fetch": { + "version": "1.7.3", + "resolved": "https://registry.npmjs.org/node-fetch/-/node-fetch-1.7.3.tgz", + "integrity": "sha512-NhZ4CsKx7cYm2vSrBAr2PvFOe6sWDf0UYLRqA6svUYg7+/TSfVAu49jYC4BvQ4Sms9SZgdqGBgroqfDhJdTyKQ==", + "requires": { + "encoding": "^0.1.11", + "is-stream": "^1.0.1" + } + }, + "object-assign": { + "version": "4.1.1", + "resolved": "https://registry.npmjs.org/object-assign/-/object-assign-4.1.1.tgz", + "integrity": "sha1-IQmtx5ZYh8/AXLvUQsrIv7s2CGM=" + }, + "postcss-value-parser": { + "version": "3.3.1", + "resolved": "https://registry.npmjs.org/postcss-value-parser/-/postcss-value-parser-3.3.1.tgz", + "integrity": "sha512-pISE66AbVkp4fDQ7VHBwRNXzAAKJjw4Vw7nWI/+Q3vuly7SNfgYXvm6i5IgFylHGK5sP/xHAbB7N49OS4gWNyQ==" + }, + "promise": { + "version": "7.3.1", + "resolved": "https://registry.npmjs.org/promise/-/promise-7.3.1.tgz", + "integrity": "sha512-nolQXZ/4L+bP/UGlkfaIujX9BKxGwmQ9OT4mOt5yvy8iK1h3wqTEJCijzGANTCCl9nWjY41juyAn2K3Q1hLLTg==", + "requires": { + "asap": "~2.0.3" + } + }, + "prop-types": { + "version": "15.6.2", + "resolved": "https://registry.npmjs.org/prop-types/-/prop-types-15.6.2.tgz", + "integrity": "sha512-3pboPvLiWD7dkI3qf3KbUe6hKFKa52w+AE0VCqECtf+QHAKgOL37tTaNCnuX1nAAQ4ZhyP+kYVKf8rLmJ/feDQ==", + "requires": { + "loose-envify": "^1.3.1", + "object-assign": "^4.1.1" + } + }, + "react-is": { + "version": "16.6.3", + "resolved": "https://registry.npmjs.org/react-is/-/react-is-16.6.3.tgz", + "integrity": "sha512-u7FDWtthB4rWibG/+mFbVd5FvdI20yde86qKGx4lVUTWmPlSWQ4QxbBIrrs+HnXGbxOUlUzTAP/VDmvCwaP2yA==" + }, + "react-test-renderer": { + "version": "16.6.3", + "resolved": "https://registry.npmjs.org/react-test-renderer/-/react-test-renderer-16.6.3.tgz", + "integrity": "sha512-B5bCer+qymrQz/wN03lT0LppbZUDRq6AMfzMKrovzkGzfO81a9T+PWQW6MzkWknbwODQH/qpJno/yFQLX5IWrQ==", + "dev": true, + "requires": { + "object-assign": "^4.1.1", + "prop-types": "^15.6.2", + "react-is": "^16.6.3", + "scheduler": "^0.11.2" + } + }, + "resolve-url": { + "version": "0.2.1", + "resolved": "https://registry.npmjs.org/resolve-url/-/resolve-url-0.2.1.tgz", + "integrity": "sha1-LGN/53yJOv0qZj/iGqkIAGjiBSo=", + "dev": true + }, + "safer-buffer": { + "version": "2.1.2", + "resolved": "https://registry.npmjs.org/safer-buffer/-/safer-buffer-2.1.2.tgz", + "integrity": "sha512-YZo3K82SD7Riyi0E1EQPojLz7kpepnSQI9IyPbHHg1XXXevb5dJI7tpyN2ADxGcQbHG7vcyRHk0cbwqcQriUtg==" + }, + "scheduler": { + "version": "0.11.3", + "resolved": "https://registry.npmjs.org/scheduler/-/scheduler-0.11.3.tgz", + "integrity": "sha512-i9X9VRRVZDd3xZw10NY5Z2cVMbdYg6gqFecfj79USv1CFN+YrJ3gIPRKf1qlY+Sxly4djoKdfx1T+m9dnRB8kQ==", + "dev": true, + "requires": { + "loose-envify": "^1.1.0", + "object-assign": "^4.1.1" + } + }, + "setimmediate": { + "version": "1.0.5", + "resolved": "https://registry.npmjs.org/setimmediate/-/setimmediate-1.0.5.tgz", + "integrity": "sha1-KQy7Iy4waULX1+qbg3Mqt4VvgoU=" + }, + "source-map": { + "version": "0.6.1", + "resolved": "https://registry.npmjs.org/source-map/-/source-map-0.6.1.tgz", + "integrity": "sha512-UjgapumWlbMhkBgzT7Ykc5YXUT46F0iKu8SGXq0bcwP5dz/h0Plj6enJqjz1Zbq2l5WaqYnrVbwWOWMyF3F47g==", + "dev": true + }, + "source-map-resolve": { + "version": "0.5.2", + "resolved": "https://registry.npmjs.org/source-map-resolve/-/source-map-resolve-0.5.2.tgz", + "integrity": "sha512-MjqsvNwyz1s0k81Goz/9vRBe9SZdB09Bdw+/zYyO+3CuPk6fouTaxscHkgtE8jKvf01kVfl8riHzERQ/kefaSA==", + "dev": true, + "requires": { + "atob": "^2.1.1", + "decode-uri-component": "^0.2.0", + "resolve-url": "^0.2.1", + "source-map-url": "^0.4.0", + "urix": "^0.1.0" + } + }, + "source-map-url": { + "version": "0.4.0", + "resolved": "https://registry.npmjs.org/source-map-url/-/source-map-url-0.4.0.tgz", + "integrity": "sha1-PpNdfd1zYxuXZZlW1VEo6HtQhKM=", + "dev": true + }, + "styled-components": { + "version": "4.1.3", + "resolved": "https://registry.npmjs.org/styled-components/-/styled-components-4.1.3.tgz", + "integrity": "sha512-0quV4KnSfvq5iMtT0RzpMGl/Dg3XIxIxOl9eJpiqiq4SrAmR1l1DLzNpMzoy3DyzdXVDMJS2HzROnXscWA3SEw==", + "requires": { + "@babel/helper-module-imports": "^7.0.0", + "@emotion/is-prop-valid": "^0.7.3", + "@emotion/unitless": "^0.7.0", + "babel-plugin-styled-components": ">= 1", + "css-to-react-native": "^2.2.2", + "memoize-one": "^4.0.0", + "prop-types": "^15.5.4", + "react-is": "^16.6.0", + "stylis": "^3.5.0", + "stylis-rule-sheet": "^0.0.10", + "supports-color": "^5.5.0" + } + }, + "stylis": { + "version": "3.5.4", + "resolved": "https://registry.npmjs.org/stylis/-/stylis-3.5.4.tgz", + "integrity": "sha512-8/3pSmthWM7lsPBKv7NXkzn2Uc9W7NotcwGNpJaa3k7WMM1XDCA4MgT5k/8BIexd5ydZdboXtU90XH9Ec4Bv/Q==" + }, + "stylis-rule-sheet": { + "version": "0.0.10", + "resolved": "https://registry.npmjs.org/stylis-rule-sheet/-/stylis-rule-sheet-0.0.10.tgz", + "integrity": "sha512-nTbZoaqoBnmK+ptANthb10ZRZOGC+EmTLLUxeYIuHNkEKcmKgXX1XWKkUBT2Ac4es3NybooPe0SmvKdhKJZAuw==" + }, + "supports-color": { + "version": "5.5.0", + "resolved": "https://registry.npmjs.org/supports-color/-/supports-color-5.5.0.tgz", + "integrity": "sha512-QjVjwdXIt408MIiAqCX4oUKsgU2EqAGzs2Ppkm4aQYbjm+ZEWEcW4SfFNTr4uMNZma0ey4f5lgLrkB0aX0QMow==", + "requires": { + "has-flag": "^3.0.0" + } + }, + "to-fast-properties": { + "version": "2.0.0", + "resolved": "https://registry.npmjs.org/to-fast-properties/-/to-fast-properties-2.0.0.tgz", + "integrity": "sha1-3F5pjL0HkmW8c+A3doGk5Og/YW4=" + }, + "ua-parser-js": { + "version": "0.7.19", + "resolved": "https://registry.npmjs.org/ua-parser-js/-/ua-parser-js-0.7.19.tgz", + "integrity": "sha512-T3PVJ6uz8i0HzPxOF9SWzWAlfN/DavlpQqepn22xgve/5QecC+XMCAtmUNnY7C9StehaV6exjUCI801lOI7QlQ==" + }, + "urix": { + "version": "0.1.0", + "resolved": "https://registry.npmjs.org/urix/-/urix-0.1.0.tgz", + "integrity": "sha1-2pN/emLiH+wf0Y1Js1wpNQZ6bHI=", + "dev": true + }, + "whatwg-fetch": { + "version": "3.0.0", + "resolved": "https://registry.npmjs.org/whatwg-fetch/-/whatwg-fetch-3.0.0.tgz", + "integrity": "sha512-9GSJUgz1D4MfyKU7KRqwOjXCXTqWdFNvEr7eUBYchQiVc744mqK/MzXPNR2WsPkmkOa4ywfg8C2n8h+13Bey1Q==" + } + } +} diff --git a/packages/components/psammead-figure/package.json b/packages/components/psammead-figure/package.json new file mode 100644 index 0000000000..965cf0b6d6 --- /dev/null +++ b/packages/components/psammead-figure/package.json @@ -0,0 +1,33 @@ +{ + "name": "@bbc/psammead-figure", + "version": "0.1.3", + "main": "dist/index.js", + "description": "React styled components for a Headline and SubHeading", + "repository": { + "type": "git", + "url": "https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-figure" + }, + "author": { + "name": "Psammead Maintainers", + "email": "PsammeadMaintainers@bbc.co.uk" + }, + "license": "Apache-2.0", + "bugs": { + "url": "https://github.com/bbc/psammead/issues" + }, + "homepage": "https://github.com/BBC-News/psammead/blob/latest/packages/components/psammead-figure/README.md", + "dependencies": { + "@bbc/gel-constants": "^0.1.1", + "@bbc/psammead-styles": "^0.1.3", + "styled-components": "^4.1.2" + }, + "devDependencies": { + "@bbc/psammead-test-helpers": "^0.1.0" + }, + "keywords": [ + "bbc", + "headings", + "headline", + "subheading" + ] +} \ No newline at end of file diff --git a/packages/components/psammead-figure/__snapshots__/index.test.jsx.snap b/packages/components/psammead-figure/src/__snapshots__/index.test.jsx.snap similarity index 86% rename from packages/components/psammead-figure/__snapshots__/index.test.jsx.snap rename to packages/components/psammead-figure/src/__snapshots__/index.test.jsx.snap index 95455aac6c..ef9a462e78 100644 --- a/packages/components/psammead-figure/__snapshots__/index.test.jsx.snap +++ b/packages/components/psammead-figure/src/__snapshots__/index.test.jsx.snap @@ -3,7 +3,6 @@ exports[`Figure should render correctly 1`] = ` .c0 { margin: 0; - padding-bottom: 1rem; width: 100%; } diff --git a/packages/components/psammead-figure/src/index.jsx b/packages/components/psammead-figure/src/index.jsx index c9c4346213..7091385b9f 100644 --- a/packages/components/psammead-figure/src/index.jsx +++ b/packages/components/psammead-figure/src/index.jsx @@ -1,5 +1,5 @@ import styled from 'styled-components'; -import { GEL_SPACING_DBL } from '../../lib/constants/styles'; +import { GEL_SPACING_DBL } from '@bbc/gel-constants/breakpoints'; const Figure = styled.figure` margin: 0; diff --git a/packages/components/psammead-figure/src/index.test.jsx b/packages/components/psammead-figure/src/index.test.jsx index f7c049b466..8961a05576 100644 --- a/packages/components/psammead-figure/src/index.test.jsx +++ b/packages/components/psammead-figure/src/index.test.jsx @@ -1,5 +1,5 @@ import React from 'react'; -import { shouldMatchSnapshot } from '../../helpers/tests/testHelpers'; +import { shouldMatchSnapshot } from '@bbc/psammead-test-helpers'; import Figure from '.'; describe('Figure', () => { diff --git a/packages/components/psammead-headings/package-lock.json b/packages/components/psammead-headings/package-lock.json index 9d52bae4a5..71bb6a37b2 100644 --- a/packages/components/psammead-headings/package-lock.json +++ b/packages/components/psammead-headings/package-lock.json @@ -92,12 +92,12 @@ }, "babel-plugin-syntax-jsx": { "version": "6.18.0", - "resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" }, "core-js": { "version": "1.2.7", - "resolved": "https://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" }, "css": { diff --git a/packages/components/psammead-paragraph/package-lock.json b/packages/components/psammead-paragraph/package-lock.json index b1f63cf5c6..47d146a51c 100644 --- a/packages/components/psammead-paragraph/package-lock.json +++ b/packages/components/psammead-paragraph/package-lock.json @@ -92,12 +92,12 @@ }, "babel-plugin-syntax-jsx": { "version": "6.18.0", - "resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" }, "core-js": { "version": "1.2.7", - "resolved": "https://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" }, "css": { diff --git a/packages/components/psammead-sitewide-links/package-lock.json b/packages/components/psammead-sitewide-links/package-lock.json index e4e8496f93..bca94284cb 100644 --- a/packages/components/psammead-sitewide-links/package-lock.json +++ b/packages/components/psammead-sitewide-links/package-lock.json @@ -92,12 +92,12 @@ }, "babel-plugin-syntax-jsx": { "version": "6.18.0", - "resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" }, "core-js": { "version": "1.2.7", - "resolved": "https://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" }, "css": { diff --git a/packages/components/psammead-visually-hidden-text/package-lock.json b/packages/components/psammead-visually-hidden-text/package-lock.json index 286cece147..3674e066d9 100644 --- a/packages/components/psammead-visually-hidden-text/package-lock.json +++ b/packages/components/psammead-visually-hidden-text/package-lock.json @@ -73,12 +73,12 @@ }, "babel-plugin-syntax-jsx": { "version": "6.18.0", - "resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" }, "core-js": { "version": "1.2.7", - "resolved": "https://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" }, "css": { diff --git a/packages/utilities/gel-foundations-styled-components/package-lock.json b/packages/utilities/gel-foundations-styled-components/package-lock.json index a3ca17f775..dba58bf4a3 100644 --- a/packages/utilities/gel-foundations-styled-components/package-lock.json +++ b/packages/utilities/gel-foundations-styled-components/package-lock.json @@ -62,12 +62,12 @@ }, "babel-plugin-syntax-jsx": { "version": "6.18.0", - "resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" }, "core-js": { "version": "1.2.7", - "resolved": "https://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" }, "css-color-keywords": { From b713869d0dcbd86466cd2e4f9efe482317452761 Mon Sep 17 00:00:00 2001 From: radiocontrolled Date: Mon, 17 Dec 2018 15:34:05 +0000 Subject: [PATCH 03/19] remove package-locks --- packages/components/psammead-brand/package-lock.json | 4 ++-- packages/components/psammead-caption/package-lock.json | 4 ++-- packages/components/psammead-headings/package-lock.json | 4 ++-- packages/components/psammead-paragraph/package-lock.json | 4 ++-- packages/components/psammead-sitewide-links/package-lock.json | 4 ++-- .../psammead-visually-hidden-text/package-lock.json | 4 ++-- .../gel-foundations-styled-components/package-lock.json | 4 ++-- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/packages/components/psammead-brand/package-lock.json b/packages/components/psammead-brand/package-lock.json index fe67ffc959..f654a54c38 100644 --- a/packages/components/psammead-brand/package-lock.json +++ b/packages/components/psammead-brand/package-lock.json @@ -91,12 +91,12 @@ }, "babel-plugin-syntax-jsx": { "version": "6.18.0", - "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" }, "core-js": { "version": "1.2.7", - "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "resolved": "https://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" }, "css": { diff --git a/packages/components/psammead-caption/package-lock.json b/packages/components/psammead-caption/package-lock.json index 441aa2306b..6362c1dc94 100644 --- a/packages/components/psammead-caption/package-lock.json +++ b/packages/components/psammead-caption/package-lock.json @@ -111,12 +111,12 @@ }, "babel-plugin-syntax-jsx": { "version": "6.18.0", - "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" }, "core-js": { "version": "1.2.7", - "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "resolved": "https://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" }, "css": { diff --git a/packages/components/psammead-headings/package-lock.json b/packages/components/psammead-headings/package-lock.json index 71bb6a37b2..9d52bae4a5 100644 --- a/packages/components/psammead-headings/package-lock.json +++ b/packages/components/psammead-headings/package-lock.json @@ -92,12 +92,12 @@ }, "babel-plugin-syntax-jsx": { "version": "6.18.0", - "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" }, "core-js": { "version": "1.2.7", - "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "resolved": "https://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" }, "css": { diff --git a/packages/components/psammead-paragraph/package-lock.json b/packages/components/psammead-paragraph/package-lock.json index 47d146a51c..b1f63cf5c6 100644 --- a/packages/components/psammead-paragraph/package-lock.json +++ b/packages/components/psammead-paragraph/package-lock.json @@ -92,12 +92,12 @@ }, "babel-plugin-syntax-jsx": { "version": "6.18.0", - "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" }, "core-js": { "version": "1.2.7", - "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "resolved": "https://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" }, "css": { diff --git a/packages/components/psammead-sitewide-links/package-lock.json b/packages/components/psammead-sitewide-links/package-lock.json index bca94284cb..e4e8496f93 100644 --- a/packages/components/psammead-sitewide-links/package-lock.json +++ b/packages/components/psammead-sitewide-links/package-lock.json @@ -92,12 +92,12 @@ }, "babel-plugin-syntax-jsx": { "version": "6.18.0", - "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" }, "core-js": { "version": "1.2.7", - "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "resolved": "https://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" }, "css": { diff --git a/packages/components/psammead-visually-hidden-text/package-lock.json b/packages/components/psammead-visually-hidden-text/package-lock.json index 3674e066d9..286cece147 100644 --- a/packages/components/psammead-visually-hidden-text/package-lock.json +++ b/packages/components/psammead-visually-hidden-text/package-lock.json @@ -73,12 +73,12 @@ }, "babel-plugin-syntax-jsx": { "version": "6.18.0", - "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" }, "core-js": { "version": "1.2.7", - "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "resolved": "https://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" }, "css": { diff --git a/packages/utilities/gel-foundations-styled-components/package-lock.json b/packages/utilities/gel-foundations-styled-components/package-lock.json index dba58bf4a3..a3ca17f775 100644 --- a/packages/utilities/gel-foundations-styled-components/package-lock.json +++ b/packages/utilities/gel-foundations-styled-components/package-lock.json @@ -62,12 +62,12 @@ }, "babel-plugin-syntax-jsx": { "version": "6.18.0", - "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" }, "core-js": { "version": "1.2.7", - "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "resolved": "https://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" }, "css-color-keywords": { From 9f0c1637cb00e6b4c0e46eef79ebd63328d901f9 Mon Sep 17 00:00:00 2001 From: radiocontrolled Date: Mon, 17 Dec 2018 15:36:54 +0000 Subject: [PATCH 04/19] remove package-lock psammead-copyright --- packages/components/psammead-copyright/package-lock.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/components/psammead-copyright/package-lock.json b/packages/components/psammead-copyright/package-lock.json index 815b411ab3..8793d9f6d8 100644 --- a/packages/components/psammead-copyright/package-lock.json +++ b/packages/components/psammead-copyright/package-lock.json @@ -92,12 +92,12 @@ }, "babel-plugin-syntax-jsx": { "version": "6.18.0", - "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" }, "core-js": { "version": "1.2.7", - "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "resolved": "https://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" }, "css": { From 35e94b2fa4e372c08d5145098ac814904d50c59b Mon Sep 17 00:00:00 2001 From: radiocontrolled Date: Mon, 17 Dec 2018 16:44:10 +0000 Subject: [PATCH 05/19] add documentation --- packages/components/psammead-figure/README.md | 34 +++++++++++++++++++ .../components/psammead-figure/package.json | 9 ++--- 2 files changed, 37 insertions(+), 6 deletions(-) diff --git a/packages/components/psammead-figure/README.md b/packages/components/psammead-figure/README.md index 5986cbe0ae..188f7b3f9c 100644 --- a/packages/components/psammead-figure/README.md +++ b/packages/components/psammead-figure/README.md @@ -2,10 +2,44 @@ ## Description +The `psammead-figure` component is a styled `
` element. + ## When to use this component +The HTML `
` element represents self-contained content. It usually wraps an image. + +The following example shows `psammead-figure` wrapping an +* [psammead-image-placeholder](https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-image-placeholder), a `
` with background image +* [psammead-image](https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-image), an `` +* [psammead-caption](https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-caption), a `
` +* [psammead-visually-hidden-text](https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-visually-hidden-text), a hidden `` available only to assitive technology + + +``` +import Caption from '@bbc/psammead-caption'; +import Figure from '@bbc/psammead-figure'; +import Image from '@bbc/psammead-image'; +import ImagePlaceholder from '@bbc/psammead-image-placeholder'; +import VisuallyHiddenText from '@bbc/psammead-visually-hidden-text'; + +const Wrapper = ({ src, alt, ratio, captionText }) => ( +
+ + {alt} + + + Image caption, + {captionText} + +
+); + +``` + ## Accessibility notes +The `psammead-figure` is a `
` element with associated styles. When you use this component, it has the same semantic meaning as a regular [figure](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/figure) element. + ## Contributing Psammead is completely open source. We are grateful for any contributions, whether they be new components, bug fixes or general improvements. Please see our primary contributing guide which can be found at [the root of the Psammead respository](https://github.com/BBC-News/psammead/blob/latest/CONTRIBUTING.md). diff --git a/packages/components/psammead-figure/package.json b/packages/components/psammead-figure/package.json index 965cf0b6d6..705fbd6860 100644 --- a/packages/components/psammead-figure/package.json +++ b/packages/components/psammead-figure/package.json @@ -2,7 +2,7 @@ "name": "@bbc/psammead-figure", "version": "0.1.3", "main": "dist/index.js", - "description": "React styled components for a Headline and SubHeading", + "description": "React styled component that generates a figure element", "repository": { "type": "git", "url": "https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-figure" @@ -18,7 +18,6 @@ "homepage": "https://github.com/BBC-News/psammead/blob/latest/packages/components/psammead-figure/README.md", "dependencies": { "@bbc/gel-constants": "^0.1.1", - "@bbc/psammead-styles": "^0.1.3", "styled-components": "^4.1.2" }, "devDependencies": { @@ -26,8 +25,6 @@ }, "keywords": [ "bbc", - "headings", - "headline", - "subheading" + "figure" ] -} \ No newline at end of file +} From dbb51a6b4cff6d03baa93cf5e510c8dfa0fdf199 Mon Sep 17 00:00:00 2001 From: radiocontrolled Date: Mon, 17 Dec 2018 16:52:07 +0000 Subject: [PATCH 06/19] update readme --- packages/components/psammead-figure/README.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/components/psammead-figure/README.md b/packages/components/psammead-figure/README.md index 188f7b3f9c..3b949977c5 100644 --- a/packages/components/psammead-figure/README.md +++ b/packages/components/psammead-figure/README.md @@ -6,7 +6,7 @@ The `psammead-figure` component is a styled `
` element. ## When to use this component -The HTML `
` element represents self-contained content. It usually wraps an image. +Use this component when a `
` element, which represents self-contained content that frequently has a caption, is required. Figures usually wrap an image. The following example shows `psammead-figure` wrapping an * [psammead-image-placeholder](https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-image-placeholder), a `
` with background image @@ -14,7 +14,6 @@ The following example shows `psammead-figure` wrapping an * [psammead-caption](https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-caption), a `
` * [psammead-visually-hidden-text](https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-visually-hidden-text), a hidden `` available only to assitive technology - ``` import Caption from '@bbc/psammead-caption'; import Figure from '@bbc/psammead-figure'; From 68d7806f43f0619353025949a20cd04e25bb2ddc Mon Sep 17 00:00:00 2001 From: radiocontrolled Date: Tue, 18 Dec 2018 09:33:14 +0000 Subject: [PATCH 07/19] add react to psammead-figure --- packages/components/psammead-figure/package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/components/psammead-figure/package.json b/packages/components/psammead-figure/package.json index 705fbd6860..f9b4fc4a12 100644 --- a/packages/components/psammead-figure/package.json +++ b/packages/components/psammead-figure/package.json @@ -21,7 +21,8 @@ "styled-components": "^4.1.2" }, "devDependencies": { - "@bbc/psammead-test-helpers": "^0.1.0" + "@bbc/psammead-test-helpers": "^0.1.0", + "react": "^16.6.3" }, "keywords": [ "bbc", From 9f1f299077c89b6a7de149a5ab055c840fc376bf Mon Sep 17 00:00:00 2001 From: Drew McMillan Date: Tue, 18 Dec 2018 09:40:34 +0000 Subject: [PATCH 08/19] Update packages/components/psammead-figure/package.json Co-Authored-By: radiocontrolled --- packages/components/psammead-figure/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/psammead-figure/package.json b/packages/components/psammead-figure/package.json index f9b4fc4a12..25cf256db7 100644 --- a/packages/components/psammead-figure/package.json +++ b/packages/components/psammead-figure/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-figure", - "version": "0.1.3", + "version": "0.1.0", "main": "dist/index.js", "description": "React styled component that generates a figure element", "repository": { From b7beb29c954d7ef850df4d8fbe1f4ae59e15e182 Mon Sep 17 00:00:00 2001 From: radiocontrolled Date: Tue, 18 Dec 2018 10:04:56 +0000 Subject: [PATCH 09/19] update package-lock --- .../psammead-figure/package-lock.json | 28 +++++++++---------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/packages/components/psammead-figure/package-lock.json b/packages/components/psammead-figure/package-lock.json index 4889a9a142..784f235b0e 100644 --- a/packages/components/psammead-figure/package-lock.json +++ b/packages/components/psammead-figure/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-figure", - "version": "0.1.3", + "version": "0.1.0", "lockfileVersion": 1, "requires": true, "dependencies": { @@ -35,20 +35,6 @@ "resolved": "https://registry.npmjs.org/@bbc/gel-constants/-/gel-constants-0.1.2.tgz", "integrity": "sha512-QNCSNe9PasApNIm9cira3pbk5y3CrYtlm5jukLRUo70O5IXMYQw9xaaMbB083Y5qZzP//3UeMjU94S1ZwsHExg==" }, - "@bbc/gel-foundations-styled-components": { - "version": "0.1.1", - "resolved": "https://registry.npmjs.org/@bbc/gel-foundations-styled-components/-/gel-foundations-styled-components-0.1.1.tgz", - "integrity": "sha512-jzfv2L7hs+0rEyk6HjFIJ7sQIP8dqddCbBJov2GaWVyA+OEJLF6D69U0o3mgjPh677XZeTb7swCa8rhykSlnuQ==", - "requires": { - "@bbc/gel-constants": "^0.1.1", - "styled-components": "^4.1.1" - } - }, - "@bbc/psammead-styles": { - "version": "0.1.4", - "resolved": "https://registry.npmjs.org/@bbc/psammead-styles/-/psammead-styles-0.1.4.tgz", - "integrity": "sha512-lrt2SjpDQqUpGIONOgeo5rl9Y9pZfKfQOdkg6fr4xOd4YxN0wdlzhlMz6TinmOSK7S9r4cKY+H0HgEDNOqUmIg==" - }, "@bbc/psammead-test-helpers": { "version": "0.1.0", "resolved": "https://registry.npmjs.org/@bbc/psammead-test-helpers/-/psammead-test-helpers-0.1.0.tgz", @@ -270,6 +256,18 @@ "object-assign": "^4.1.1" } }, + "react": { + "version": "16.6.3", + "resolved": "https://registry.npmjs.org/react/-/react-16.6.3.tgz", + "integrity": "sha512-zCvmH2vbEolgKxtqXL2wmGCUxUyNheYn/C+PD1YAjfxHC54+MhdruyhO7QieQrYsYeTxrn93PM2y0jRH1zEExw==", + "dev": true, + "requires": { + "loose-envify": "^1.1.0", + "object-assign": "^4.1.1", + "prop-types": "^15.6.2", + "scheduler": "^0.11.2" + } + }, "react-is": { "version": "16.6.3", "resolved": "https://registry.npmjs.org/react-is/-/react-is-16.6.3.tgz", From 6734179c028e10f253989e4b658884c6b6203730 Mon Sep 17 00:00:00 2001 From: Sareh Date: Tue, 18 Dec 2018 10:06:56 +0000 Subject: [PATCH 10/19] Update packages/components/psammead-figure/README.md Co-Authored-By: radiocontrolled --- packages/components/psammead-figure/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/psammead-figure/README.md b/packages/components/psammead-figure/README.md index 3b949977c5..9a4abc9494 100644 --- a/packages/components/psammead-figure/README.md +++ b/packages/components/psammead-figure/README.md @@ -14,7 +14,7 @@ The following example shows `psammead-figure` wrapping an * [psammead-caption](https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-caption), a `
` * [psammead-visually-hidden-text](https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-visually-hidden-text), a hidden `` available only to assitive technology -``` +```jsx import Caption from '@bbc/psammead-caption'; import Figure from '@bbc/psammead-figure'; import Image from '@bbc/psammead-image'; From 77c75f63a02b66b0c1a23c7fa3855f8351fcc978 Mon Sep 17 00:00:00 2001 From: radiocontrolled Date: Tue, 18 Dec 2018 10:31:47 +0000 Subject: [PATCH 11/19] fix missing padding in figure snapshot --- packages/components/psammead-figure/package-lock.json | 6 +++--- packages/components/psammead-figure/package.json | 2 +- .../psammead-figure/src/__snapshots__/index.test.jsx.snap | 1 + packages/components/psammead-figure/src/index.jsx | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/components/psammead-figure/package-lock.json b/packages/components/psammead-figure/package-lock.json index 784f235b0e..fd85907471 100644 --- a/packages/components/psammead-figure/package-lock.json +++ b/packages/components/psammead-figure/package-lock.json @@ -30,10 +30,10 @@ "to-fast-properties": "^2.0.0" } }, - "@bbc/gel-constants": { + "@bbc/gel-foundations": { "version": "0.1.2", - "resolved": "https://registry.npmjs.org/@bbc/gel-constants/-/gel-constants-0.1.2.tgz", - "integrity": "sha512-QNCSNe9PasApNIm9cira3pbk5y3CrYtlm5jukLRUo70O5IXMYQw9xaaMbB083Y5qZzP//3UeMjU94S1ZwsHExg==" + "resolved": "https://registry.npmjs.org/@bbc/gel-foundations/-/gel-foundations-0.1.2.tgz", + "integrity": "sha512-OXIxdYBeJ0dt0iMyGxhCmqiywpo5gg/nubaI+5ANMIVchqF68oCY72KU7DYKvTkBOfWxTDnsDApn60c28d07Dw==" }, "@bbc/psammead-test-helpers": { "version": "0.1.0", diff --git a/packages/components/psammead-figure/package.json b/packages/components/psammead-figure/package.json index 25cf256db7..94ac687340 100644 --- a/packages/components/psammead-figure/package.json +++ b/packages/components/psammead-figure/package.json @@ -17,7 +17,7 @@ }, "homepage": "https://github.com/BBC-News/psammead/blob/latest/packages/components/psammead-figure/README.md", "dependencies": { - "@bbc/gel-constants": "^0.1.1", + "@bbc/gel-foundations": "^0.1.2", "styled-components": "^4.1.2" }, "devDependencies": { diff --git a/packages/components/psammead-figure/src/__snapshots__/index.test.jsx.snap b/packages/components/psammead-figure/src/__snapshots__/index.test.jsx.snap index ef9a462e78..95455aac6c 100644 --- a/packages/components/psammead-figure/src/__snapshots__/index.test.jsx.snap +++ b/packages/components/psammead-figure/src/__snapshots__/index.test.jsx.snap @@ -3,6 +3,7 @@ exports[`Figure should render correctly 1`] = ` .c0 { margin: 0; + padding-bottom: 1rem; width: 100%; } diff --git a/packages/components/psammead-figure/src/index.jsx b/packages/components/psammead-figure/src/index.jsx index 7091385b9f..1f086e3fae 100644 --- a/packages/components/psammead-figure/src/index.jsx +++ b/packages/components/psammead-figure/src/index.jsx @@ -1,5 +1,5 @@ import styled from 'styled-components'; -import { GEL_SPACING_DBL } from '@bbc/gel-constants/breakpoints'; +import { GEL_SPACING_DBL } from '@bbc/gel-foundations/spacings'; const Figure = styled.figure` margin: 0; From 99680901d410017c76b6fe4a2cebd336a6d9309e Mon Sep 17 00:00:00 2001 From: Chris Ashton Date: Wed, 19 Dec 2018 11:56:01 +0000 Subject: [PATCH 12/19] Update packages/components/psammead-figure/README.md Co-Authored-By: radiocontrolled --- packages/components/psammead-figure/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/psammead-figure/README.md b/packages/components/psammead-figure/README.md index 9a4abc9494..5219ff98b7 100644 --- a/packages/components/psammead-figure/README.md +++ b/packages/components/psammead-figure/README.md @@ -12,7 +12,7 @@ The following example shows `psammead-figure` wrapping an * [psammead-image-placeholder](https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-image-placeholder), a `
` with background image * [psammead-image](https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-image), an `` * [psammead-caption](https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-caption), a `
` -* [psammead-visually-hidden-text](https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-visually-hidden-text), a hidden `` available only to assitive technology +* [psammead-visually-hidden-text](https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-visually-hidden-text), a hidden `` available only to assistive technology ```jsx import Caption from '@bbc/psammead-caption'; From c6c152b63e3d0905ddc0ec0e6de5195a2aad3f55 Mon Sep 17 00:00:00 2001 From: radiocontrolled Date: Wed, 19 Dec 2018 12:30:45 +0000 Subject: [PATCH 13/19] storybook story --- .../psammead-figure/package-lock.json | 10 +++++++ .../components/psammead-figure/package.json | 1 + .../psammead-figure/src/index.stories.jsx | 26 +++++++++++++++++++ 3 files changed, 37 insertions(+) create mode 100644 packages/components/psammead-figure/src/index.stories.jsx diff --git a/packages/components/psammead-figure/package-lock.json b/packages/components/psammead-figure/package-lock.json index fd85907471..9210330272 100644 --- a/packages/components/psammead-figure/package-lock.json +++ b/packages/components/psammead-figure/package-lock.json @@ -35,6 +35,16 @@ "resolved": "https://registry.npmjs.org/@bbc/gel-foundations/-/gel-foundations-0.1.2.tgz", "integrity": "sha512-OXIxdYBeJ0dt0iMyGxhCmqiywpo5gg/nubaI+5ANMIVchqF68oCY72KU7DYKvTkBOfWxTDnsDApn60c28d07Dw==" }, + "@bbc/psammead-image": { + "version": "0.1.0", + "resolved": "https://registry.npmjs.org/@bbc/psammead-image/-/psammead-image-0.1.0.tgz", + "integrity": "sha512-3v7X9boLf2QU+k8iuHQb//FtKQiGI2KPZ3Gwf6EUTSk/nl7VcfdvuF7ZeI+ENtUBYi5m4ii5t1oM+BLE8f6ESQ==", + "dev": true, + "requires": { + "prop-types": "^15.6.2", + "styled-components": "^4.1.2" + } + }, "@bbc/psammead-test-helpers": { "version": "0.1.0", "resolved": "https://registry.npmjs.org/@bbc/psammead-test-helpers/-/psammead-test-helpers-0.1.0.tgz", diff --git a/packages/components/psammead-figure/package.json b/packages/components/psammead-figure/package.json index 94ac687340..94a8a8bcae 100644 --- a/packages/components/psammead-figure/package.json +++ b/packages/components/psammead-figure/package.json @@ -22,6 +22,7 @@ }, "devDependencies": { "@bbc/psammead-test-helpers": "^0.1.0", + "@bbc/psammead-image": "^0.1.0", "react": "^16.6.3" }, "keywords": [ diff --git a/packages/components/psammead-figure/src/index.stories.jsx b/packages/components/psammead-figure/src/index.stories.jsx new file mode 100644 index 0000000000..911ed251a8 --- /dev/null +++ b/packages/components/psammead-figure/src/index.stories.jsx @@ -0,0 +1,26 @@ +import React from 'react'; +import { storiesOf } from '@storybook/react'; +import { withReadme } from 'storybook-readme'; +import Image from '@bbc/psammead-image'; +import Readme from '../README.md'; +import Figure from './index'; + +const imageAlt = + 'Map of the UK displaying Syrian refugees and asylum seekers per 10000 population. Ranges from 0 to 17.'; +const imageSrc = + 'https://ichef.bbci.co.uk/news/640/cpsprodpb/439A/production/_100960371_syrians_and_asylum_v2-nc.png'; +const imageWidth = 853; +const imageHeight = 1067; + +storiesOf('Figure', module) + .addDecorator(withReadme(Readme)) + .add('default', () => ( +
+ {imageAlt} +
+ )); From 3d3e58b66a6a98b2691b08cd8531de2b36e7f94b Mon Sep 17 00:00:00 2001 From: Chris Ashton Date: Wed, 19 Dec 2018 13:35:19 +0000 Subject: [PATCH 14/19] Update packages/components/psammead-figure/README.md Co-Authored-By: radiocontrolled --- packages/components/psammead-figure/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/components/psammead-figure/README.md b/packages/components/psammead-figure/README.md index 5219ff98b7..f648023091 100644 --- a/packages/components/psammead-figure/README.md +++ b/packages/components/psammead-figure/README.md @@ -32,7 +32,6 @@ const Wrapper = ({ src, alt, ratio, captionText }) => (
); - ``` ## Accessibility notes From e7da14526fc429cf6fcc89ec1bd994b67dffdf95 Mon Sep 17 00:00:00 2001 From: Sareh Date: Wed, 19 Dec 2018 13:36:00 +0000 Subject: [PATCH 15/19] Update packages/components/psammead-figure/README.md Co-Authored-By: radiocontrolled --- packages/components/psammead-figure/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/psammead-figure/README.md b/packages/components/psammead-figure/README.md index f648023091..227d99b954 100644 --- a/packages/components/psammead-figure/README.md +++ b/packages/components/psammead-figure/README.md @@ -1,4 +1,4 @@ -# psammead-figure · [![GitHub license](https://img.shields.io/badge/license-Apache%202.0-blue.svg)](https://github.com/BBC-News/psammead/blob/latest/LICENSE) [![npm version](https://img.shields.io/npm/v/@bbc/psammead-figure.svg)](https://www.npmjs.com/package/@bbc/psammead-figure) [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)](https://github.com/BBC-News/psammead/blob/latest/CONTRIBUTING.md) +# psammead-figure · [![Storybook](https://github.com/storybooks/press/blob/master/badges/storybook.svg)](https://bbc-news.github.io/psammead/?selectedKind=Figure) [![GitHub license](https://img.shields.io/badge/license-Apache%202.0-blue.svg)](https://github.com/BBC-News/psammead/blob/latest/LICENSE) [![npm version](https://img.shields.io/npm/v/@bbc/psammead-figure.svg)](https://www.npmjs.com/package/@bbc/psammead-figure) [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)](https://github.com/BBC-News/psammead/blob/latest/CONTRIBUTING.md) ## Description From b906d57ef0ce0e38b603f5a63a89177fedfff68c Mon Sep 17 00:00:00 2001 From: radiocontrolled Date: Wed, 19 Dec 2018 13:49:38 +0000 Subject: [PATCH 16/19] remove height from image in story --- packages/components/psammead-figure/package-lock.json | 4 ++-- .../components/psammead-figure/src/index.stories.jsx | 9 +-------- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/packages/components/psammead-figure/package-lock.json b/packages/components/psammead-figure/package-lock.json index 9210330272..4b15396260 100644 --- a/packages/components/psammead-figure/package-lock.json +++ b/packages/components/psammead-figure/package-lock.json @@ -97,12 +97,12 @@ }, "babel-plugin-syntax-jsx": { "version": "6.18.0", - "resolved": "http://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", + "resolved": "https://registry.npmjs.org/babel-plugin-syntax-jsx/-/babel-plugin-syntax-jsx-6.18.0.tgz", "integrity": "sha1-CvMqmm4Tyno/1QaeYtew9Y0NiUY=" }, "core-js": { "version": "1.2.7", - "resolved": "http://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", + "resolved": "https://registry.npmjs.org/core-js/-/core-js-1.2.7.tgz", "integrity": "sha1-ZSKUwUZR2yj6k70tX/KYOk8IxjY=" }, "css": { diff --git a/packages/components/psammead-figure/src/index.stories.jsx b/packages/components/psammead-figure/src/index.stories.jsx index 911ed251a8..ebc66d5426 100644 --- a/packages/components/psammead-figure/src/index.stories.jsx +++ b/packages/components/psammead-figure/src/index.stories.jsx @@ -10,17 +10,10 @@ const imageAlt = const imageSrc = 'https://ichef.bbci.co.uk/news/640/cpsprodpb/439A/production/_100960371_syrians_and_asylum_v2-nc.png'; const imageWidth = 853; -const imageHeight = 1067; - storiesOf('Figure', module) .addDecorator(withReadme(Readme)) .add('default', () => (
- {imageAlt} + {imageAlt}
)); From 5215a379d9cb9be5d217eb8e0819e117db1f93e3 Mon Sep 17 00:00:00 2001 From: Chris Ashton Date: Thu, 20 Dec 2018 10:15:48 +0000 Subject: [PATCH 17/19] Update packages/components/psammead-figure/src/index.stories.jsx Co-Authored-By: radiocontrolled --- packages/components/psammead-figure/src/index.stories.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/psammead-figure/src/index.stories.jsx b/packages/components/psammead-figure/src/index.stories.jsx index ebc66d5426..b537a40952 100644 --- a/packages/components/psammead-figure/src/index.stories.jsx +++ b/packages/components/psammead-figure/src/index.stories.jsx @@ -3,7 +3,7 @@ import { storiesOf } from '@storybook/react'; import { withReadme } from 'storybook-readme'; import Image from '@bbc/psammead-image'; import Readme from '../README.md'; -import Figure from './index'; +import Figure from '.'; const imageAlt = 'Map of the UK displaying Syrian refugees and asylum seekers per 10000 population. Ranges from 0 to 17.'; From f1ef98aa3aa4e70fee690082b737eac3a51a3126 Mon Sep 17 00:00:00 2001 From: radiocontrolled Date: Thu, 20 Dec 2018 10:55:41 +0000 Subject: [PATCH 18/19] update story and documentation --- packages/components/psammead-figure/README.md | 4 ++-- packages/components/psammead-figure/src/index.stories.jsx | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/components/psammead-figure/README.md b/packages/components/psammead-figure/README.md index 227d99b954..95425eec88 100644 --- a/packages/components/psammead-figure/README.md +++ b/packages/components/psammead-figure/README.md @@ -21,10 +21,10 @@ import Image from '@bbc/psammead-image'; import ImagePlaceholder from '@bbc/psammead-image-placeholder'; import VisuallyHiddenText from '@bbc/psammead-visually-hidden-text'; -const Wrapper = ({ src, alt, ratio, captionText }) => ( +const Wrapper = ({ alt, captionText, ratio, src, width }) => (
- {alt} + {alt} Image caption, diff --git a/packages/components/psammead-figure/src/index.stories.jsx b/packages/components/psammead-figure/src/index.stories.jsx index b537a40952..aad3feffc8 100644 --- a/packages/components/psammead-figure/src/index.stories.jsx +++ b/packages/components/psammead-figure/src/index.stories.jsx @@ -12,7 +12,7 @@ const imageSrc = const imageWidth = 853; storiesOf('Figure', module) .addDecorator(withReadme(Readme)) - .add('default', () => ( + .add('Figure containing Image', () => (
{imageAlt}
From 20963bbbd7d902cc5582748a32e6f9d47e6e1938 Mon Sep 17 00:00:00 2001 From: radiocontrolled Date: Thu, 20 Dec 2018 10:58:41 +0000 Subject: [PATCH 19/19] change to spelling --- packages/components/psammead-figure/src/index.stories.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/psammead-figure/src/index.stories.jsx b/packages/components/psammead-figure/src/index.stories.jsx index aad3feffc8..650cb812df 100644 --- a/packages/components/psammead-figure/src/index.stories.jsx +++ b/packages/components/psammead-figure/src/index.stories.jsx @@ -12,7 +12,7 @@ const imageSrc = const imageWidth = 853; storiesOf('Figure', module) .addDecorator(withReadme(Readme)) - .add('Figure containing Image', () => ( + .add('containing Image', () => (
{imageAlt}