From e4d38fa33d820205247c77eec51c16b09f4c9921 Mon Sep 17 00:00:00 2001 From: sadickisaac Date: Tue, 27 Aug 2019 14:13:54 +0300 Subject: [PATCH 1/2] Use @testing-library/react --- .../psammead-media-player/src/Placeholder/index.test.jsx | 9 ++++----- packages/utilities/psammead-test-helpers/CHANGELOG.md | 1 + .../utilities/psammead-test-helpers/package-lock.json | 2 +- packages/utilities/psammead-test-helpers/package.json | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/components/psammead-media-player/src/Placeholder/index.test.jsx b/packages/components/psammead-media-player/src/Placeholder/index.test.jsx index b45d63c273..1cc911e3df 100644 --- a/packages/components/psammead-media-player/src/Placeholder/index.test.jsx +++ b/packages/components/psammead-media-player/src/Placeholder/index.test.jsx @@ -1,6 +1,6 @@ import React from 'react'; +import { render, fireEvent } from '@testing-library/react'; import { shouldMatchSnapshot } from '@bbc/psammead-test-helpers'; -import renderer from 'react-test-renderer'; import Placeholder from '.'; describe('Media Player: Placeholder', () => { @@ -16,14 +16,13 @@ describe('Media Player: Placeholder', () => { ); it('should call onClick when clicked', () => { - const tree = renderer.create( + const { container } = render( , ); - - tree.root.findByType('div').props.onClick(); - expect(mockOnClick.mock.calls.length).toEqual(1); + fireEvent.click(container.firstChild); + expect(mockOnClick).toHaveBeenCalledTimes(1); }); }); diff --git a/packages/utilities/psammead-test-helpers/CHANGELOG.md b/packages/utilities/psammead-test-helpers/CHANGELOG.md index 814801a67c..086c5500eb 100644 --- a/packages/utilities/psammead-test-helpers/CHANGELOG.md +++ b/packages/utilities/psammead-test-helpers/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | |---------|-------------| +| 1.3.2 | [PR#???](https://github.com/bbc/psammead/pull/???) Use @testing-library-react | | 1.3.1 | [PR#1849](https://github.com/bbc/psammead/pull/1849) Update README.md | | 1.3.0 | [PR#1846](https://github.com/bbc/psammead/pull/1846/) Import test helper functions from simorgh | | 1.2.1 | [PR#1803](https://github.com/bbc/psammead/pull/1803/) Patches broken links on badges in documentation | diff --git a/packages/utilities/psammead-test-helpers/package-lock.json b/packages/utilities/psammead-test-helpers/package-lock.json index 77084a0747..a753d4ce26 100644 --- a/packages/utilities/psammead-test-helpers/package-lock.json +++ b/packages/utilities/psammead-test-helpers/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-test-helpers", - "version": "1.3.1", + "version": "1.3.2", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/utilities/psammead-test-helpers/package.json b/packages/utilities/psammead-test-helpers/package.json index 60797ddf51..087f1a7fc4 100644 --- a/packages/utilities/psammead-test-helpers/package.json +++ b/packages/utilities/psammead-test-helpers/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-test-helpers", - "version": "1.3.1", + "version": "1.3.2", "main": "dist/index.js", "module": "esm/index.js", "sideEffects": false, From 383f7c8b47c6d0c534eb7385eef0420744fb2bac Mon Sep 17 00:00:00 2001 From: sadickisaac Date: Tue, 27 Aug 2019 14:19:41 +0300 Subject: [PATCH 2/2] Update PR number --- packages/utilities/psammead-test-helpers/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/utilities/psammead-test-helpers/CHANGELOG.md b/packages/utilities/psammead-test-helpers/CHANGELOG.md index 086c5500eb..777a9378a0 100644 --- a/packages/utilities/psammead-test-helpers/CHANGELOG.md +++ b/packages/utilities/psammead-test-helpers/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | |---------|-------------| -| 1.3.2 | [PR#???](https://github.com/bbc/psammead/pull/???) Use @testing-library-react | +| 1.3.2 | [PR#1919](https://github.com/bbc/psammead/pull/1919) Use @testing-library-react | | 1.3.1 | [PR#1849](https://github.com/bbc/psammead/pull/1849) Update README.md | | 1.3.0 | [PR#1846](https://github.com/bbc/psammead/pull/1846/) Import test helper functions from simorgh | | 1.2.1 | [PR#1803](https://github.com/bbc/psammead/pull/1803/) Patches broken links on badges in documentation |