Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Do not host BBC Fonts locally for Storybook #3835

Closed
1 task
karinathomasbbc opened this issue Oct 7, 2020 · 1 comment
Closed
1 task

Do not host BBC Fonts locally for Storybook #3835

karinathomasbbc opened this issue Oct 7, 2020 · 1 comment
Labels
Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. technical-work Technical debt, support work and building new technical tools and features

Comments

@karinathomasbbc
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Many BBC Fonts are hosted in .storybook/fonts, however this is duplication, and also a maintenance overhead if fonts change over time

Describe the solution you'd like
The fonts are already hosted on ws-downloads - we should use the corresponding URLs here - so that they are downloaded from a single location

Describe alternatives you've considered

Testing notes
[Tester to complete]

Dev insight: Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
Original comment from @simonsinclair #3832 (review)

@karinathomasbbc karinathomasbbc added the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Oct 7, 2020
@karinathomasbbc karinathomasbbc added this to the BBC Reith Qalam Font milestone Oct 7, 2020
@karinathomasbbc
Copy link
Contributor Author

This might not be possible - #2873

@joshcoventry joshcoventry added the technical-work Technical debt, support work and building new technical tools and features label Dec 3, 2020
@joshcoventry joshcoventry removed this from the BBC Reith Qalam Font milestone Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. technical-work Technical debt, support work and building new technical tools and features
Projects
None yet
Development

No branches or pull requests

2 participants