Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Simplify psammead-media-player #2544

Closed
1 task done
simonsinclair opened this issue Nov 4, 2019 · 2 comments
Closed
1 task done

Simplify psammead-media-player #2544

simonsinclair opened this issue Nov 4, 2019 · 2 comments
Labels
articles-av-epic backlog Things not being worked on for this quarter Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test.

Comments

@simonsinclair
Copy link
Contributor

simonsinclair commented Nov 4, 2019

Is your feature request related to a problem? Please describe.
The successful integration of Media Player into various areas of Simorgh, plus additional features like Play Button and Guidance has meant a vast increase in its complexity over the past couple of weeks.

It contains three major components - Placeholder, CanonicalMediaPlayer and AmpMediaPlayer - and has upwards of 15 properties, with more expected. We'd like to determine whether this component can be simplified and what this would look like.

Describe the solution you'd like

  • Does grouping props (like mediaInfo) help us or not?
  • Should Placeholder be a dependency of Media Player or not?
    • Placeholder itself is a growing component, with additional features requiring new properties.
  • Should Guidance be a more generic Overlay component?

Describe alternatives you've considered
n/a

Testing notes
[Tester to complete]

Dev insight: Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.

@simonsinclair simonsinclair added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-articles Tasks for the WS Articles Team articles-av-epic ws-media The World Service media stream labels Nov 4, 2019
@aeroplanejane
Copy link

Hey @simonsinclair is this ticket a duplicate of bbc/simorgh#4361? Can it be closed?

@simonsinclair
Copy link
Contributor Author

Hey @simonsinclair is this ticket a duplicate of bbc/simorgh#4361? Can it be closed?

Hey @aeroplanejane, this issue relates to Psammead Media Player and not the news-av-player Morph module. 🙂

@simonsinclair simonsinclair changed the title Simplify Media Player Simplify psammead-media-player Nov 22, 2019
@amywalkerdev amywalkerdev added backlog Things not being worked on for this quarter and removed ws-articles Tasks for the WS Articles Team ws-media The World Service media stream labels Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
articles-av-epic backlog Things not being worked on for this quarter Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test.
Projects
None yet
Development

No branches or pull requests

4 participants