Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Create Script Link component #2255

Closed
1 task
j-pendlebury opened this issue Sep 30, 2019 · 4 comments · Fixed by #2294
Closed
1 task

Create Script Link component #2255

j-pendlebury opened this issue Sep 30, 2019 · 4 comments · Fixed by #2294
Labels
a11y-swarm An a11y swarm (clarify dev or full team in the desc) needs to be carried out before moving to test ws-home Tasks for the WS Home Team

Comments

@j-pendlebury
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We now have services with variants, so we need a script switch.

Describe the solution you'd like
Build a component which can be used to switch between variants.

This will be an alpha component.

image

Site Variant Link label to open this Variant
Serbian https://www.bbc.com/serbian/lat Lat
Serbian https://www.bbc.com/serbian/cyr Ћир
UK China https://www.bbc.com/ukchina/simp 简 (translation for Simp)
UK China https://www.bbc.com/ukchina/trad 繁 (translation for Trad)
Zhongwen https://www.bbc.com/zhongwen/trad 简 (translation for Simp)
Zhongwen https://www.bbc.com/zhongwen/simp 繁 (translation for Trad)

Testing notes
[Tester to complete]

  • This feature is expected to need manual testing.

Additional context
WSFRONTPGS-100
@j-pendlebury j-pendlebury added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-home Tasks for the WS Home Team ws-fp-phase3 labels Sep 30, 2019
@AlistairGempf
Copy link
Contributor

Have seperate stories for the component by itself, and another integrating it into the brand.

@AlistairGempf
Copy link
Contributor

Display site not currently on in component, eg. display "Lat" on Cyrillic Serbian site.

@AlistairGempf AlistairGempf removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Sep 30, 2019
@AlistairGempf AlistairGempf added the a11y-swarm An a11y swarm (clarify dev or full team in the desc) needs to be carried out before moving to test label Sep 30, 2019
@AlistairGempf AlistairGempf mentioned this issue Sep 30, 2019
Closed
1 task
@ghost ghost self-assigned this Sep 30, 2019
@ghost
Copy link

ghost commented Sep 30, 2019

@jblaut at 600 and 240px breakpoint have not states defined hover and focus what should happen? should we use 320 px.

@ghost ghost removed their assignment Oct 1, 2019
@ghost ghost self-assigned this Oct 1, 2019
@j-pendlebury
Copy link
Contributor Author

@sadickisaac sorry, just saw your comment.

Double checked with Fan - hover and focus states should be the same on all breakpoints

@ghost ghost mentioned this issue Oct 2, 2019
Merged
3 tasks
@ghost ghost closed this as completed in #2294 Oct 8, 2019
@DenisHdz DenisHdz changed the title Create Script Switch component Create Script Link component Oct 9, 2019
@DenisHdz DenisHdz mentioned this issue Oct 10, 2019
Merged
3 tasks
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a11y-swarm An a11y swarm (clarify dev or full team in the desc) needs to be carried out before moving to test ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create Script Link component BBC-archive/psammead
2 participants
@j-pendlebury @AlistairGempf