Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Multiple charts per page? #4

Open
skipchris opened this issue Dec 5, 2016 · 5 comments
Open

Multiple charts per page? #4

skipchris opened this issue Dec 5, 2016 · 5 comments

Comments

@skipchris
Copy link

Hi,

I might be making a mistake, in which case sorry for the non-issue, but it currently doesn’t seem possible to use Chart.Bands on a page which contains both a bar and a line graph – the isSupported flag is set ‘globally’ rather than on a per-chart basis.

I’ve worked around this locally by removing the isSupported check, and instead checking for a per-instance bands config option, and only trying to apply the plugin if this param is present.

I’m happy to submit this as a PR, and update the README to match, would you like this, or am I missing something important?

@martov1
Copy link

martov1 commented Feb 2, 2017

oh man thanks for pointing that out, I have been fighting this problem for 2 hours.

@EdwardLuke
Copy link
Contributor

Hi @skipchris - I don't think you're missing anything important. If you'd still like to submit that PR, feel free (although I realise this message has been a long time coming!)

@skipchris
Copy link
Author

😂

OK, I am currently on leave for a month, but I would still like this little clean-up, so I hope to tackle it at some point Feb/March

@EdwardLuke
Copy link
Contributor

Ha, enjoy your leave! Great - I'll keep an eye out 👍

@thormug
Copy link

thormug commented Jan 27, 2020

There is a lot of problems when you have multiple charts on the same page with plugin.
Everything seems to be set globally, when you try to render 2 line charts, the plugin does mistakes.

ChartJSMultipleProblems

I'm supposed to have the top rendering, but if it load after the other chart, it looks like that.
The belowThresholdColour is screwed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants