Migrate Headings components into component package #79
Conversation
dr3
changed the title
|
This PR has a new |
dr3
added
the
blocked
dr3
removed
the
blocked
|
|
||
| | Version | Description | | ||
| |---------|-------------| | ||
| | 0.1.0 | [PR#79](https://github.com/BBC-News/psammead/pull/79) Create initial package, pulled in from [simorgh](https://github.com/BBC-News/simorgh). | |
There was a problem hiding this comment.
Shouldn't this be 1.0.0? I appreciate we may still make tweaks to the component as and when we discover complexities, but wouldn't have thought we risk having to publish a v2 any time soon.
There was a problem hiding this comment.
@ChrisBAshton This issue that's just been opened against this component: #88 is removing a prop. This would require a major bump in the version number.
There was a problem hiding this comment.
Re: it being 0.1.0 not 1.0.0 thats just the convention we have used for the other packages
There was a problem hiding this comment.
Ha, fair point! I'd argue it's a minor (1.1) as continuing to supply the prop wouldn't break compilation. But maybe we should keep everything as 0.1.0 until all components are moved, then mass-upgrade them all to v1 when we're happy...
There was a problem hiding this comment.
I agree that it'd be good to keep it at 0.1.0 to start with, since there can be breaking changes before version 1.0.0 is released.
Co-Authored-By: dr3 <drew.mcmillan@bbc.co.uk>
Co-Authored-By: dr3 <drew.mcmillan@bbc.co.uk>
Co-Authored-By: dr3 <drew.mcmillan@bbc.co.uk>
Co-Authored-By: dr3 <drew.mcmillan@bbc.co.uk>
Co-Authored-By: dr3 <drew.mcmillan@bbc.co.uk>
Resolves #12
Moves the Headings components into a psammead package