This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Add support for high contrast mode and print and no css #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisBAshton
reviewed
Jan 3, 2019
| @@ -20,6 +20,7 @@ The `Brand` component is designed to be used where a BBC logo is required as SVG | |||
| ## Accessibility notes | |||
| * Visually hidden text is provided (e.g. for screen reader users) | |||
| * `Brand` is keyboard-accessible and provides hover and focus styles | |||
| * The brand SVG has support for users with css disabled or high contrast mode enabled. | |||
| @@ -77,11 +85,11 @@ const Brand = ({ brandName }) => ( | |||
| focusable="false" | |||
| aria-hidden="true" | |||
| > | |||
| <g fill="#fff" fillRule="evenodd"> | |||
| <SvgGroup fill="#000" fillRule="evenodd"> | |||
There was a problem hiding this comment.
Why the change to #000 here?
There was a problem hiding this comment.
Its the default for when CSS is disabled
radiocontrolled
previously approved these changes
Jan 3, 2019
bcmn
previously approved these changes
Jan 3, 2019
pjlee11
approved these changes
Jan 3, 2019
bcmn
approved these changes
Jan 4, 2019
|
@dr3 does this work for setting custom modes (colours) in High Contrast Mode on PC? |
|
@greenc05 It uses the default font colour that the user assigns |
|
Fabulous, great work @dr3 |
|
As we have no means of testing this on a local Psammead environment (excluding Storybook, which wouldn't give an accurate representation as it's an iFrame on a page), we're going to merge this then push to Test. We're going to test the logic on Test. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #252
Resolves bbc/simorgh#860
Resolves bbc/simorgh#378
Ensures the svg is always visible if in high contrast mode, when printing and when css is disabled
ORIGINAL
NOW - Windows 7 IE9 Normal
NOW - Windows 7 IE9 High Contrast white
NOW - Windows 7 IE9 High Contrast
NOW - Mac Print
NOW - Mac no css
Known problems that will be fixed in other issues -
Testing notes -
The SVG should be visible (white on red background, or black on white background) when: