This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Image stretching fix #234
Merged
Image stretching fix #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: sareh <sareh.heidari@gmail.com>
ChrisBAshton
suggested changes
Dec 19, 2018
There was a problem hiding this comment.
Can we update the README and make it clear the height is optional (and the implications for specifying it)? https://github.com/BBC-News/psammead/tree/latest/packages/components/psammead-image#usage
| @@ -2,4 +2,5 @@ | |||
|
|
|||
| | Version | Description | | |||
| |---------|-------------| | |||
| | 0.2.0 | [PR#234](https://github.com/BBC-News/psammead/pull/234) Change height prop to be optional. Update the storybook example. | | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ChrisBAshton
previously approved these changes
Dec 19, 2018
| | `src` | string | Yes | | ||
| | `width` | number/string | Yes | | ||
|
|
||
| The `height` prop is optional, since in some cases to preserve the image ratio we only want to specify the width and let the browser scale the image accordingly. However, in other cases the height might need to be specified. |
radiocontrolled
previously approved these changes
Dec 19, 2018
sareh
dismissed stale reviews from radiocontrolled and ChrisBAshton
via
2c3db49
bcmn
approved these changes
Dec 20, 2018
ChrisBAshton
approved these changes
Dec 20, 2018
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #232
Fixes the stretching issue by making the height prop optional.
Screenshot of the image scaling correctly with smaller breakpoints:
http://localhost:8080?selectedKind=Image