Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Create gel-foundations component and delete gel-constants and gel-foundations-styled-components #221

Merged
merged 6 commits into from
Dec 18, 2018

Conversation

dr3
Copy link
Contributor

@dr3 dr3 commented Dec 17, 2018

Resolves #178

Create gel-foundations component and delete gel-constants and gel-foundations-styled-components

When this is approved I will add a message to the top of gel-constants and gel-foundations-styled-component Readmes explaining to use the new package, publish them and deprecate the packages in npm

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@dr3 dr3 self-assigned this Dec 17, 2018
Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a tweak or two

packages/utilities/gel-foundations/CHANGELOG.md Outdated Show resolved Hide resolved
packages/utilities/gel-foundations/README.md Outdated Show resolved Hide resolved
ChrisBAshton and others added 2 commits December 17, 2018 16:10
Co-Authored-By: dr3 <drew.mcmillan@bbc.co.uk>
Co-Authored-By: dr3 <drew.mcmillan@bbc.co.uk>
Copy link
Contributor

@bcmn bcmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving -- This is going to conflict a whole bunch with my work on #212, so I'll block that ticket on this one.

@ChrisBAshton ChrisBAshton merged commit eed1552 into latest Dec 18, 2018
@ChrisBAshton ChrisBAshton deleted the gel-foundations branch December 18, 2018 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants