This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Adds Brand component to Psammead #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently having an issue using styled-components' |
mxstbr
reviewed
Dec 7, 2018
|
By the way, does this mean BBC News is building their internal component library with styled-components in the open? Because that would be incredibly exciting! 🎉 |
|
Actually the above error I comment on was because I needed to do
|
radiocontrolled
commented
Dec 7, 2018
Co-Authored-By: radiocontrolled <radiocontrolled@gmail.com>
|
Your comments are addressed @ChrisBAshton |
dr3
reviewed
Dec 7, 2018
bcmn
previously approved these changes
Dec 10, 2018
dr3
previously approved these changes
Dec 11, 2018
ChrisBAshton
previously approved these changes
Dec 11, 2018
radiocontrolled
dismissed stale reviews from ChrisBAshton and dr3
via
0d414fa
sareh
approved these changes
Dec 11, 2018
bcmn
approved these changes
Dec 11, 2018
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #56
Adds a Brand component to Psammead
screenshot
