Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msal-angular@1.0.0-beta.5 imports fail #1502

Closed
2 tasks done
jarodsmk opened this issue Apr 15, 2020 · 2 comments
Closed
2 tasks done

msal-angular@1.0.0-beta.5 imports fail #1502

jarodsmk opened this issue Apr 15, 2020 · 2 comments
Assignees
Labels
bug A problem that needs to be fixed for the feature to function as intended. msal-angular Related to @azure/msal-angular package

Comments

@jarodsmk
Copy link

Library

  • msal@1.3.0-beta.1
  • @azure/msal-angular@1.0.0-beta.5

Framework

Angular@8.2.3

Description

When bumping msal-angular to 1.0.0-beta.5, BroadcastService and MsalService can no longer be imported.

The path @azure/msal-angular doesn't resolve to a module in node_modules.

Security

None

Regression

Yes this worked before, when reverting to @azure/msal-angular@1.0.0-beta.4 it works fine.

Configuration

// Provide configuration values here.
// For Azure B2C issues, please include your policies.

config: {
      auth: {
        clientId: 'XXX',
        authority:
          'XXX',
        validateAuthority: true,
        redirectUri: 'http://localhost:4200/auth-callback',
        postLogoutRedirectUri: 'http://localhost:4200/',
        navigateToLoginRequestUrl: true,
      },
      cache: {
        cacheLocation: 'localStorage',
        storeAuthStateInCookie: false, // set to true for IE 11
      },
    },
    angularConfig: {
      popUp: false,
      consentScopes: ['openid', 'profile', 'email'],
      protectedResourceMap: [
        ['https://localhost:5001', ['openid', 'profile', 'email']],
      ],
      extraQueryParameters: {},
    },

Reproduction steps

  1. From a 1.0.0-beta release, bump it to 1.0.0-beta.5
  2. The imports previously set as per the Angular Sample App examples should fail because the module cannot be reconciled.

Expected behavior

The imports should still work after the version change.

Browsers

Not browser specific

@jarodsmk jarodsmk added the bug A problem that needs to be fixed for the feature to function as intended. label Apr 15, 2020
@tnorling tnorling added the msal-angular Related to @azure/msal-angular package label Apr 15, 2020
@jasonnutter
Copy link
Contributor

@jarodsmk I'm having trouble reproducing this with the Angular 8 sample. Installed beta 5 from npm, and everything looks good. The artifact on npm looks good as well, seems like everything is there. Are all the files there inside node_modules/@azure/msal-angular?

@jasonnutter jasonnutter self-assigned this Apr 17, 2020
@jasonnutter
Copy link
Contributor

Closing due to inactivity and the inability to reproduce the issue, please let us know if this is still an issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A problem that needs to be fixed for the feature to function as intended. msal-angular Related to @azure/msal-angular package
Projects
None yet
Development

No branches or pull requests

3 participants