urlContainsHash removed from public API

[anton-gorbikov]

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Browser:

• Chrome version XX
• Firefox version XX
• IE version XX
• Edge version XX
• Safari version XX

Library version

Library version: 1.2.0

Current behavior

urlContainsHash is missing in the public API

Expected behavior

1. urlContainsHash removal should be mentioned as a breaking change;
2. Informational messages about isCallback deprecation should not be logged as public API doesn't contain other options.

Minimal reproduction of the problem with instructions

In version 1.1.3 calling isCallback function resulted in informational message: isCallback will be deprecated in favor of urlContainsHash in MSAL.js v2.0.. We've changed the isCallback function to urlContainsHash. But in version 1.2.0 this function was removed from the UserAgentApplication prototype.

[sameerag]

@anton-gorbikov Thanks for bringing this to our notice. This was an unintended side-effect of a code consolidation made for url helper functions. Can this wait until the next release or would you need a patch?

[anton-gorbikov]

@sameerag Thanks for quick reply and confirming that it's unintended. As for me it can wait. The change in the code was minimal, I just replaced urlContainsHash back to isCallback.