Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send x-app-name and x-app-ver to query URLs #978

Closed
jmprieur opened this issue Mar 14, 2019 · 2 comments
Closed

Send x-app-name and x-app-ver to query URLs #978

jmprieur opened this issue Mar 14, 2019 · 2 comments
Assignees
@MarkZuber
Milestone
3.0.3

Comments

@jmprieur
Copy link
Contributor

jmprieur commented Mar 14, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
See add client app name and version to authorization and token requests for why and what.

What to do?

  1. In the ApplicationOptions class, add two string properties;
  • ClientName
  • ClientVersion
  • Obsolete the Component property (which was combining ClientName and Version

  1. If the developer does not provide the ClientName and ClientVersion, these are computed with values from the OS. In the case of .NET we can probably use the Assembly attributes.

  2. Append the client name and version to the following parameters when making authorization and token requests:

  • x-app-name
  • x-app-ver

.WithApplicationInformation(string clientName, string clientVersion)
@jmprieur jmprieur changed the title x-app-name and x-app-ver Send x-app-name and x-app-ver to query URLs Mar 14, 2019
@jmprieur jmprieur added this to the 3.0.2 milestone Mar 22, 2019
@jmprieur jmprieur modified the milestones: 3.0.3, 3.0.4 Apr 4, 2019
@MarkZuber MarkZuber self-assigned this Apr 4, 2019
@MarkZuber MarkZuber mentioned this issue Apr 4, 2019
Merged
@MarkZuber MarkZuber modified the milestones: 3.0.4, 3.0.3 Apr 5, 2019
@MarkZuber
Copy link
Contributor

#1044

@jennyf19
Copy link
Collaborator

jennyf19 commented Apr 8, 2019

included in msal 3.0.3-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkZuber MarkZuber

Labels
None yet
Projects
None yet
Milestone
3.0.3
Development

No branches or pull requests
3 participants
@MarkZuber @jmprieur @jennyf19