Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Update Managed Identity Exceptions to MSALServiceExceptions #4483

Closed
gladjohn opened this issue Dec 24, 2023 · 1 comment · Fixed by #4476
Closed

[Bug] Update Managed Identity Exceptions to MSALServiceExceptions #4483

gladjohn opened this issue Dec 24, 2023 · 1 comment · Fixed by #4476
Assignees
@gladjohn
Labels
bug confidential-client internal P2 scenario:ManagedIdentity
Milestone
4.59.0

Comments

@gladjohn
Copy link
Contributor

Type of task?

Development

Description

The ManagedIdentityException didn't play well with our hierarchy of exceptions, since it only derviced from ServiceException. But not from UIRequiredException. The only reason we added this exception was to be able to add extra bit of data about what source leads to this exception.

It also prevents code reuse, since any shared logic between MSI and STS now has to deal with the problem of throwing the correct exception (or catching MsalServiceEx and rethrowing MSIException, which is also complex).

Solution

No response
@gladjohn gladjohn added internal untriaged Do not delete. Needed for Automation labels Dec 24, 2023
@gladjohn gladjohn self-assigned this Dec 24, 2023
@gladjohn gladjohn added scenario:ManagedIdentity and removed untriaged Do not delete. Needed for Automation labels Dec 24, 2023
@gladjohn gladjohn mentioned this issue Dec 24, 2023
Merged
@gladjohn gladjohn moved this from Committed to In Progress in MSAL Customer Trust / QM Dec 24, 2023
@gladjohn gladjohn added this to the 4.59.0 milestone Dec 24, 2023
@pmaytak pmaytak moved this from In Progress to Waiting for Code Review in MSAL Customer Trust / QM Dec 27, 2023
@bgavrilMS
Copy link
Member

This is not an engineering task.

@gladjohn gladjohn added the bug label Jan 4, 2024
@gladjohn gladjohn changed the title [Engineering Task] Update Managed Identity Exceptions to MSALServiceExceptions [Bug] Update Managed Identity Exceptions to MSALServiceExceptions Jan 4, 2024
@gladjohn gladjohn added the P2 label Jan 4, 2024
@github-project-automation github-project-automation bot moved this from Waiting for Code Review to Done in MSAL Customer Trust / QM Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gladjohn gladjohn

Labels
bug confidential-client internal P2 scenario:ManagedIdentity
Projects
MSAL Customer Trust / QM
Archived in project
Milestone
4.59.0
2 participants
@bgavrilMS @gladjohn