Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] WAM is invoked for B2C authorities and MSAL.Desktop API is not good for B2C #4072

Closed
bgavrilMS opened this issue Apr 13, 2023 · 2 comments · Fixed by #4073
Closed

[Bug] WAM is invoked for B2C authorities and MSAL.Desktop API is not good for B2C #4072

bgavrilMS opened this issue Apr 13, 2023 · 2 comments · Fixed by #4073
Assignees
@bgavrilMS
Labels
B2C bug ICM This issue has a corresponding ICM, either for our team or another. P2 scenario:Desktop
Milestone
4.53.0

Comments

@bgavrilMS
Copy link
Member

  1. Use sample https://github.com/Azure-Samples/active-directory-b2c-dotnet-desktop
  2. Add MSAL.Desktop package and install it
.AddDesktopFeatures(BrokerOptions.Windows)

Expected: webview2 support for b2c
Actual: WAM is invoked and it fails

Proposed solution:

  1. Fallback from WAM to browser on B2C
  2. Add explicit API for WebView support, because WithDesktopFeatures(new BrokerOptions(Windows)) is not great
  3. Allow WebView2 on ADFS (no COGS implication for poor SSO)
@bgavrilMS
Copy link
Member Author

CC @neha-bhargava as ICM follow up

This was referenced Apr 13, 2023
Merged
Closed
@bgavrilMS bgavrilMS self-assigned this Apr 13, 2023
@bgavrilMS bgavrilMS added the ICM This issue has a corresponding ICM, either for our team or another. label Apr 13, 2023
@pmaytak pmaytak added this to the 4.53.0 milestone Apr 14, 2023
@rayluo
Copy link
Contributor

rayluo commented Apr 14, 2023

If we haven't already, we shall also disable WAM for ADFS. Both B2C and ADFS were documented as the fallback scenarios in our internal design docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgavrilMS bgavrilMS

Labels
B2C bug ICM This issue has a corresponding ICM, either for our team or another. P2 scenario:Desktop
Projects
MSAL Customer Trust / QM
Archived in project
Milestone
4.53.0
3 participants
@rayluo @bgavrilMS @pmaytak