Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all the error codes to MSAL.Error #1004

Closed
jmprieur opened this issue Mar 23, 2019 · 2 comments
Closed

Move all the error codes to MSAL.Error #1004

jmprieur opened this issue Mar 23, 2019 · 2 comments
Assignees
@MarkZuber
Milestone
3.0.3

Comments

@jmprieur
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Some of the error messages are constants in the exception classes whereas other are constants in the new MsalError class. We should have only one mechanism (errors in the exception types preferred when it makes sense).

Describe the solution you'd like
Move the error codes from MsalError to the right Exception class if that makes sense

Describe alternatives you've considered
Move the constants from the Msal Exceptions to the MsalError class.
@jennyf19 jennyf19 mentioned this issue Mar 28, 2019
Merged
@jmprieur jmprieur added this to the 3.0.3 milestone Mar 29, 2019
@MarkZuber MarkZuber self-assigned this Apr 2, 2019
@MarkZuber MarkZuber mentioned this issue Apr 2, 2019
Closed
@MarkZuber MarkZuber mentioned this issue Apr 3, 2019
Merged
@jmprieur jmprieur changed the title Move the error codes from MsalError to the right MSAL Exception class Move all the error codes to MSAL.Error Apr 4, 2019
@MarkZuber
Copy link
Contributor

#1039

@jennyf19
Copy link
Collaborator

jennyf19 commented Apr 8, 2019

included in msal 3.0.3-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkZuber MarkZuber

Labels
None yet
Projects
None yet
Milestone
3.0.3
Development

No branches or pull requests
3 participants
@MarkZuber @jmprieur @jennyf19