Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IP interface loopback action #2192

Merged
merged 9 commits into from
Jul 7, 2022

Conversation

liorghub
Copy link
Contributor

@liorghub liorghub commented Jun 2, 2022

What I did

Add support for IP interface loopback action.

How I did it

Add new commands and handilig, Update the commad reference guide to incldue the new show command

How to verify it

New CLI unittests were added.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

root@sonic:~# config interface ip loopback-action Ethernet0 drop
root@sonic:~# show ip interfaces loopback-action
Interface     Action      
------------  ----------  
Ethernet232   drop
Vlan100       forward    

dgsudharsan
dgsudharsan previously approved these changes Jun 13, 2022
Remove redundant check of interface existence config DB.
@liat-grozovik
Copy link
Collaborator

@dgsudharsan, @prsunny could you please review following the review comments handling?

@dgsudharsan
Copy link
Collaborator

Can you please update the description of the PR to reflect the newly updated config command syntax?

@liorghub
Copy link
Contributor Author

Can you please update the description of the PR to reflect the newly updated config command syntax?

@dgsudharsan
Done.

@liat-grozovik liat-grozovik merged commit 3600639 into sonic-net:master Jul 7, 2022
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Jul 7, 2022
Update sonic-utilities submodule pointer to include the following:
* [show] add new CLI to show tunnel route objects ([sonic-net#2255](sonic-net/sonic-utilities#2255))
* Add support for IP interface loopback action ([sonic-net#2192](sonic-net/sonic-utilities#2192))
* Update load minigraph to load backend acl ([sonic-net#2236](sonic-net/sonic-utilities#2236))
* show linkmgrd status in  ([sonic-net#2254](sonic-net/sonic-utilities#2254))

Signed-off-by: dprital <drorp@nvidia.com>
yxieca pushed a commit that referenced this pull request Jul 7, 2022
- What I did
Add support for IP interface loopback action.

- How I did it
Add new commands and handilig, Update the commad reference guide to incldue the new show command

- How to verify it
New CLI unittests were added.

Previous command output (if the output of a command-line utility has changed)
None

New command output (if the output of a command-line utility has changed)
root@sonic:~# config interface ip loopback-action Ethernet0 drop
root@sonic:~# show ip interfaces loopback-action
Interface        Action      
------------     ----------  
Ethernet232   drop
Vlan100          forward
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants