Add trap flow counter support #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junchao-Mellanox
force-pushed
the
flow-counter-review
branch
from
a35423e
to
eb997c1
Compare
|
Hi @qiluo-msft , could you please suggest a reviewer from MSFT side? Thanks! |
|
Hi @qiluo-msft , kindly reminder, could you please suggest a reviewer? |
Junchao-Mellanox
force-pushed
the
flow-counter-review
branch
from
eb997c1
to
80035f1
Compare
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Junchao-Mellanox
force-pushed
the
flow-counter-review
branch
2 times, most recently
from
8227476
to
d9563bf
Compare
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
requested review from
prsunny
and removed request for
qiluo-msft and
SuvarnaMeenakshi
Junchao-Mellanox
force-pushed
the
flow-counter-review
branch
from
d9563bf
to
298260f
Compare
Junchao-Mellanox
force-pushed
the
flow-counter-review
branch
from
298260f
to
384b1fb
Compare
|
/azpw run Azure.sonic-utilities |
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@dgsudharsan, can you review this as well? |
dgsudharsan
suggested changes
Nov 23, 2021
counterpoll/main.py
Outdated
| @@ -352,6 +386,8 @@ def show(): | |||
| data.append([ACL, pg_drop_info.get("POLL_INTERVAL", DEFLT_10_SEC), acl_info.get("FLEX_COUNTER_STATUS", DISABLE)]) | |||
| if tunnel_info: | |||
| data.append(["TUNNEL_STAT", rif_info.get("POLL_INTERVAL", DEFLT_10_SEC), rif_info.get("FLEX_COUNTER_STATUS", DISABLE)]) | |||
| if trap_info: | |||
| data.append(["FLOW_CNT_TRAP_STAT", trap_info.get("POLL_INTERVAL", DEFLT_1_SEC), trap_info.get("FLEX_COUNTER_STATUS", DISABLE)]) | |||
There was a problem hiding this comment.
Should this be changed to 10 sec?
tests/counterpoll_test.py
Outdated
| @@ -27,6 +26,7 @@ | |||
| PG_WATERMARK_STAT 10000 enable | |||
| PG_DROP_STAT 10000 enable | |||
| ACL 10000 enable | |||
| FLOW_CNT_TRAP_STAT 1000 enable | |||
There was a problem hiding this comment.
Should this be 10000?
|
|
||
| old_values = old_stats[name] | ||
| if values[-1] != old_values[-1]: | ||
| # Counter OID not equal means the trap was removed and added again. Removing a trap would cause |
There was a problem hiding this comment.
This is a good logic to handle. However, what if OID returned is the same as before delete? Should we rather not check if the diff is negative and consider it as a case where trap got deleted?
|
/azpw run Azure.sonic-utilities |
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-utilities |
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgsudharsan
approved these changes
Nov 24, 2021
keboliu
approved these changes
Nov 24, 2021
prsunny
approved these changes
Nov 25, 2021
5 tasks
Closed
5 tasks
abdosi
pushed a commit
that referenced
this pull request
Dec 8, 2021
Add flowcnt commands * counterpoll flowcnt-trap enable/disable * counterpoll flowcnt-trap interval * show flowcnt-trap stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add trap flow counter CLI support. See HLD: sonic-net/SONiC#858
How I did it
Add new command:
How to verify it
Unit test/Manual test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)