Copp Changes #1004
Copp Changes #1004
Conversation
|
Hi, @dgsudharsan! Could you please tell me when do you plan to resolve conflicts? |
scripts/db_migrator.py
Outdated
|
|
||
| self.migrate_copp_table() |
There was a problem hiding this comment.
Lets have copp table migration as part of 1_0_4? and set new as 1_0_5
There was a problem hiding this comment.
202006 version had the release version as 1_0_3. Is it ok to bump up the version twice to 1_0_5 between releases?
There was a problem hiding this comment.
We can have this part of the current version so as to execute this always
scripts/db_migrator.py
Outdated
| """ | ||
| log.log_info('Handling version_1_0_4') | ||
|
|
||
| self.migrate_copp_table() | ||
| return None |
There was a problem hiding this comment.
Please upgrade to version_1_0_5 and create function version_1_0_5 with previous code in version_1_0_4. You need to mark that upgrade is done.
There was a problem hiding this comment.
Had a discussion with @yxieca . @dgsudharsan, can we do it as part of an outer function so that this is called always instead of copying to each later versions?
There was a problem hiding this comment.
sure. after offline discussion. I think we need to put 'always apply at latest version' operations after the main upgrade loop.
| @@ -247,6 +260,7 @@ def common_migration_ops(self): | |||
| # Update all tables that do not exist in configDB but are present in INIT_CFG | |||
| for init_table_key, init_table_val in table_val.items(): | |||
| self.configDB.set_entry(init_cfg_table, init_table_key, init_table_val) | |||
| self.migrate_copp_table() | |||
scripts/fast-reboot
Outdated
| @@ -247,6 +247,14 @@ function backup_database() | |||
| end | |||
| end | |||
| " 0 > /dev/null | |||
| # Delete COPP_TABLE keys in APPL_DB | |||
There was a problem hiding this comment.
As discussed, we can remove this section
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
- What I did
Added DB migrator script for removing old copp APP DB entries.
Added warm-boot/fast-boot logic to remove Copp entries during warm-boot
- How I did it
Modified db_migrator script and incremented version
- How to verify it
Verify by performing warm-reboot from an existing version to new version with latest copp changes
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)