change direct-route(AKA subnet-route) issuer from intfsorch to routeorch #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull from origin
pull from origin
* intfsOrch add directed route by ip address configuration, but routes from fpmsyncd got data from routing protocol, which can refer to the state of interfaces. When the interface is down intfsorch still add subnet route . It will result in a wrong situation, route with same prefix from route protocol will be refused to be added to SAI. So we change direct route issuer from infsorch to routeorch. Signed-off-by: shine.chen <shine.chen@nephosinc.com>
shine4chen
changed the title
Signed-off-by: leo.li <leo.li@nephosinc.com>
|
This PR will be included in another PR, so close it |
volodymyrsamotiy
added a commit
to volodymyrsamotiy/sonic-swss
that referenced
this pull request
Sep 14, 2021
PFCWD storm detection and restoration LUA scripts require values in microseconds. Due to recent changes in swss (sonic-net#878) polling interval is now passed in milliseconds. Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…c-net#878) * Initial changes for interface, portchannel commands to support multi-asic * Updates based on the move of common API's to sonic_device_util.py * Using the namespace as string instead of unicode. Additionaly changes to update the namespace keyword to ctx.obj['namespace'] in portconfig scripts invocation. * Fix in sfputil scripts for config interface transceiver commands * Interface range not supported in multi-asic platforms - check added for now. Will add this support in future. * Updates for sonic-py-common TODO's * Updates to take care of following 1. Make namespace option "required" for interface commands also, in addition to portchannel, vlan commands 2. The namespaces choice is given to user to select the namespace option. * Updates includes the following 1. The API's interface_alias_to_name(), interface_name_is_valid(), interface_name_to_alias(), to handle the case when the input config_db is passed as "None" 2. The API get_port_namespace() API to derive the namespace if the input interface name is in alias mode. * Vlan command moved to a different file vlan.py, hence removed from this change set. * Fixes needed to get in sync with the common library changes.
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
sonic-net#878) According to https://github.com/Azure/SONiC/blob/ec6d35dd2c28491bfade19cfee990fe612f1e5e9/doc/rates-and-utilization/Rates_and_utilization_HLD.md, counterpoll command gives polling interval in milliseconds. So when converting them to seconds to be supplied to lua script this should be divide by 1000. However, syncd multiplies it by 1000. Changed the multiplication to none, and did the converting in lua script - sonic-net#1855 Fixed issue - sonic-net/sonic-buildimage#8392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
change direct route( AKA subnet-route) issuer from intfsorch to routeorch
Why I did it
intfsOrch add directed route by ip address configuration, but routes from
fpmsyncd got data from routing protocol, which can refer to the state of
interfaces. When the interface is down intfsorch still adds subnet route .
It will result in a wrong situation, route with same prefix from route
protocol will be refused to be added to SAI.
So we change direct route issuer from infsorch to routeorch.
How I verified it
Test it on nephos lab
Details if related