Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial value for weight in overlay nexthops #2096

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

shi-su
Copy link
Contributor

@shi-su shi-su commented Jan 4, 2022

What I did
Add initial value for weight in overlay nexthops.

Why I did it
Without initializing the weight variable, it may be initialized as non-zero values. This PR aims to prevent it from happening.

How I verified it

Details if related

@shi-su
Copy link
Contributor Author

shi-su commented Jan 4, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@shi-su
Copy link
Contributor Author

shi-su commented Jan 5, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@shi-su
Copy link
Contributor Author

shi-su commented Jan 5, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi
Copy link
Contributor

abdosi commented Jan 6, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

@shi-su should this PR goes to 202111? if so, can you please add the proper label?

@abdosi
Copy link
Contributor

abdosi commented Jan 6, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@shi-su
Copy link
Contributor Author

shi-su commented Jan 10, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@shi-su
Copy link
Contributor Author

shi-su commented Jan 10, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@shi-su shi-su merged commit 6dae6b8 into sonic-net:master Jan 11, 2022
judyjoseph pushed a commit that referenced this pull request Jan 17, 2022
What I did
Add initial value for weight in overlay nexthops.

Why I did it
Without initializing the weight variable, it may be initialized as non-zero values. This PR aims to prevent it from happening.
preetham-singh pushed a commit to preetham-singh/sonic-swss that referenced this pull request Aug 6, 2022
What I did
Add initial value for weight in overlay nexthops.

Why I did it
Without initializing the weight variable, it may be initialized as non-zero values. This PR aims to prevent it from happening.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants