VxLAN Tunnel Counters and Rates implementation #1859
Conversation
|
This pull request introduces 1 alert when merging b083c41 into df96059 - view on LGTM.com new alerts:
|
| @@ -511,6 +524,11 @@ bool VxlanTunnel::createTunnel(MAP_T encap, MAP_T decap, uint8_t encap_ttl) | |||
|
|
|||
| ids_.tunnel_id = create_tunnel(&ids_, ip, NULL, gUnderlayIfId, false, encap_ttl); | |||
|
|
|||
| if (ids_.tunnel_id != SAI_NULL_OBJECT_ID) | |||
There was a problem hiding this comment.
There could be race conditions at syncd as the create_tunnel call is through the ASIC_DB whereas the addTunnelToFlexCounter is through COUNTER DB.
Please look at intfsorch::doTask where there is a check for the VID to RID of the tunnel object before adding the flex counters to the counter db.
There was a problem hiding this comment.
yea, it will not be instantly available, only after apply_view command
| @@ -885,6 +907,11 @@ bool VxlanTunnel::createTunnelHw(uint8_t mapper_list, tunnel_map_use_t map_src, | |||
|
|
|||
| ids_.tunnel_id = create_tunnel(&ids_, &ips, ip, gUnderlayIfId, p2p); | |||
|
|
|||
| if (ids_.tunnel_id != SAI_NULL_OBJECT_ID) | |||
There was a problem hiding this comment.
same comment as for P2MP tunnel regarding the race condition
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@srj102 I have addressed your comments. Can you please review and sign off? |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…nic-net#1859) Fix sonic-net/sonic-buildimage#8888 Warn user to save the config instead of saving the kdump config in config_db.json under the covers. Having more than one actors operate on config_db.json can result in an exception.
* Tunnel stats support
* Tunnel stats support Fixing constructor in vxlantunnelorch Fixing build issue Increase polling intervals for tunnel to 10s
What I did
Implemented counters and rates for VxLAN.
Why I did it
To display vxlan counters and to enable counterpoll for tunnel counters.
How I verified it
Verified using vs tests
Details if related
Added a generic directory structure for flex counter manager. Currently tunnel counters are written for VxLAN but in future it might be expanded to other tunnels which might use the same flex counter infra.