[port_rates][rif_rates] Fix port_rates.lua #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
|
retest vs please |
|
@lguohan this fix is needed for sonic-net/sonic-mgmt#2434 |
lguohan
approved these changes
Dec 3, 2020
|
@vboykox, do we need to backport this to previous 201911 branch? |
3 tasks
|
@lguohan, no |
daall
pushed a commit
to daall/sonic-swss
that referenced
this pull request
Dec 7, 2020
Previously, loop sets DONE state on processing the first port, leaving the rest of the ports' states uninitialized. Now, the fix set rate collect logic init state per port. Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Fix for hanging: Enforce max len on string to be printed to stdout. With huge mismatch, the message to print can be too long to hang python print statement. Lower logging level: The log for "details of route mismatch" is lowered to WARNING. The caller of the route_check may log error, as it sees it fit. The failure of route_check is indicated to caller via exit code. How to verify it Simulate error (route-mismatch), and verify a) message len does not exceed set MAX b) log level is WARNING
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volodymyr Boyko volodymyrx.boiko@intel.com
What I did
Set rate collect logic init state per port
Why I did it
Observing following syslog:
Nov 26 19:34:28.821608 sonic ERR syncd[26]: :- guard: RedisReply catches system_error: command: *39#015#012$7#015#012EVALSHA#015#012$40#015#0121140a72bbf8e5306e589cb798796067294922901#015#012$2#015#01232#015#012$19#015#012oid:0x600000000034f#015#012$19#015#012oid:0x6000000000350#015#012$19#015#012oid:0x6000000000351#015#012$19#015#012oid:0x6000000000352#015#012$19#015#012oid:0x6000000000353#015#012$19#015#012oid:0x6000000000354#015#012$19#015#012oid:0x6000000000355#015#012$19#015#012oid:0x6000000000356#015#012$19#015#012oid:0x6000000000357#015#012$19#015#012oid:0x6000000000358#015#012$19#015#012oid:0x6000000000359#015#012$19#015#012oid:0x600000000035a#015#012$19#015#012oid:0x600000000035b#015#012$19#015#012oid:0x600000000035c#015#012$19#015#012oid:0x600000000035d#015#012$19#015#012oid:0x600000000035e#015#012$19#015#012oid:0x600000000035f#015#012$19#015#012oid:0x6000000000360#015#012$19#015#012oid:0x6000000000361#015#012$19#015#012oid:0x6000000000362#015#012$19#015#012oid:0x6000000000363#015#012$19#015#012oid:0x6000000000364#015#012$19#015#012oid:0x6000000000365#015#012$19#015#012oid:0x6000000000366#015#012$19#015#012oid:0x6000000000367#015#012$19#015#012oid:0x6000000000368#015#012$19#015#012oid:0x6000000000369#015#012$19#015#012oid:0x600000000036a#015#012$19#015#012oid:0x600000000036b#015#012$19#015#012oid:0x600000000036c#015#012$19#015#012oid:0x600000000036d#015#012$19#015#012oid:0x600000000036e#015#012$1#015#0122#015#012$8#015#012COUNTERS#015#012$7#015#0121000000#015#012$2#015#012''#015#012, reason: ERR Error running script (call to f_1140a72bbf8e5306e589cb798796067294922901): @user_script:47: user_script:47: attempt to perform arithmetic on local 'in_octets_last' (a boolean value) : Input/output error Nov 26 19:34:28.821608 sonic ERR syncd[26]: :- runRedisScript: Caught exception while running Redis lua script: ERR Error running script (call to f_1140a72bbf8e5306e589cb798796067294922901): @user_script:47: user_script:47: attempt to perform arithmetic on local 'in_octets_last' (a boolean value) : Input/output errorloop sets DONE state on processing the first port, leaving the rest of the ports' states uninitialized.
How I verified it
Checked redis-cli -n 2 hgetall RATES:oid: to ensure
_lastfields are set.Details if related