Code changes to support IPv6 Link local enhancements #1463

AkhileshSamineni · 2020-10-10T13:21:23Z

Code changes :

Changes to handle the "ipv6_use_link_local_only" option on a interface which is added/deleted based on Global Config or Interface config.
Adds/Deletes the RIF for an interface in the absence of IPv6 global address on a interface based on "ipv6_use_link_local_only".
Allow the ipv6 link-local address as neighbors.
Allow adding the IPv6 routes with link-local nexthops.
Changes in fpm to handle ipv6 nexthop with ipv4 prefix (as BGP is going to send ipv6 link-local as the nexthop in case of 5549).
Skip Ipv4LL neighbor add in Orchagent for RFC5549.

As per HLD - sonic-net/SONiC#625

Depends on :
sonic-net/sonic-utilities#1159
sonic-net/sonic-buildimage#5584

Signed-off-by: Akhilesh Samineni akhilesh.samineni@broadcom.com

AkhileshSamineni · 2020-10-22T07:36:32Z

retest vs please

batmancn · 2021-01-04T07:16:25Z

Hi, all

I'm testing this patch, but I got this error:

Jan  4 13:22:32.653510 dut-testbed NOTICE swss#orchagent: :- addIp2MeRoute: Create IP2me route ip:fe80::320d:9eff:fe00:121
Jan  4 13:22:32.661766 dut-testbed NOTICE swss#orchagent: :- doTask: Route 10.0.0.0/31: resize ipv to match alsv, 0 -> 1.
Jan  4 13:22:32.661766 dut-testbed NOTICE swss#orchagent: :- doTask: Route 10.0.0.0/31: set the empty nexthop ip to zero.
Jan  4 13:22:32.661918 dut-testbed NOTICE swss#orchagent: :- doTask: Route fc00::/126: resize ipv to match alsv, 0 -> 1.
Jan  4 13:22:32.661918 dut-testbed NOTICE swss#orchagent: :- doTask: Route fc00::/126: set the empty nexthop ip to zero.
Jan  4 13:22:32.662021 dut-testbed NOTICE swss#orchagent: :- doTask: Route fe80::/64: resize ipv to match alsv, 0 -> 1.
Jan  4 13:22:32.662021 dut-testbed NOTICE swss#orchagent: :- doTask: Route fe80::/64: set the empty nexthop ip to zero.
Jan  4 13:22:32.708112 dut-testbed NOTICE swss#orchagent: :- doTask: Get port state change notification id:1000000000003 status:1
Jan  4 13:22:32.708349 dut-testbed NOTICE swss#orchagent: :- setHostIntfsOperStatus: Set operation status UP to host interface Ethernet2
Jan  4 13:22:32.710027 dut-testbed ERR swss#orchagent: :- meta_sai_validate_route_entry: object key SAI_OBJECT_TYPE_ROUTE_ENTRY:{"dest":"fe80::320d:9eff:fe00:121/128","switch_id":"oid:0x21000000000000","vr":"oid:0x300000000003a"} already exists
Jan  4 13:22:32.710027 dut-testbed ERR swss#orchagent: :- addIp2MeRoute: %%intfsorch_sai: Failed to create IP2me route ip:fe80::320d:9eff:fe00:121, rv:-6
Jan  4 13:22:32.710428 dut-testbed INFO swss#supervisord: orchagent terminate called after throwing an instance of 'std::runtime_error'
Jan  4 13:22:32.710883 dut-testbed INFO swss#supervisord: orchagent   what():  Failed to create IP2me route.

I found this error is because "swss add same route twice or more".
"swss add same route twice or more" is because each INTERFACE has a IPv6 LLA, so swss will add IP2ME route for each INTERFACE's IPv6 LLA.

So how to deal with this?

AkhileshSamineni · 2021-04-08T06:33:25Z

@arlakshm Please retest it, as I don't have permission for Azurepipelines run.

AkhileshSamineni · 2021-04-09T10:30:05Z

/azp run

azure-pipelines · 2021-04-09T10:30:11Z

Commenter does not have sufficient privileges for PR 1463 in repo Azure/sonic-swss

AkhileshSamineni · 2021-04-09T10:30:50Z

@arlakshm @prsunny Please retest it, as I don't have permission for Azurepipelines run.

arlakshm · 2021-04-12T18:30:07Z

/Azp run

azure-pipelines · 2021-04-12T18:30:21Z

Azure Pipelines successfully started running 1 pipeline(s).

AkhileshSamineni · 2021-04-15T14:37:02Z

The failures are not related to the code changes, Please check it.

AkhileshSamineni · 2021-05-03T11:05:05Z

Please re-run the build, as the failures are not related to the code changes.

anshuv-mfst · 2021-05-04T15:58:34Z

@arlakshm - could you please help with re-run.

lguohan · 2021-05-04T15:59:23Z

can you add vstest?

prsunny · 2021-05-05T01:53:09Z

@AkhileshSamineni , can you do a rebase and push?

lgtm-com · 2021-06-07T13:07:24Z

This pull request introduces 1 alert when merging a726b09 into 5847af3 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call

AkhileshSamineni · 2021-06-07T20:06:54Z

can you add vstest?

@lguohan Added VS test cases.

AkhileshSamineni · 2021-06-07T20:08:41Z

@AkhileshSamineni , can you do a rebase and push?

@lguohan @prsunny Done rebase and pushed the changes. Now I see vrf_creation is failing in most of the test cases, which were not related to my changes. Could you please check.

orchagent/vrforch.cpp

fpmsyncd/routesync.cpp

neighsyncd/neighsync.cpp

orchagent/neighorch.cpp

AkhileshSamineni · 2021-06-16T06:58:16Z

/azpw run

AkhileshSamineni · 2021-06-16T06:59:00Z

/AzurePipelines run

azure-pipelines · 2021-06-16T06:59:05Z

Commenter does not have sufficient privileges for PR 1463 in repo Azure/sonic-swss

cfgmgr/intfmgr.cpp

venkatmahalingam

Changes to handle the "ipv6_use_link_local_only" option on a interface which is added/deleted based on Global Config or Interface config.

I think, BGP unnumbered use-case is expected to work without this field explicitly configured as ipv6 enabled by default globally on all interfaces i.e LLA should be present., right?
Wondering what's the expectation on the community image for BGP unnumbered functionality to work,
Should we need to disable ipv6 on all interfaces globally first and then enable per interface basis?

Adds/Deletes the RIF for an interface in the absence of IPv6 global address on a interface based on "ipv6_use_link_local_only".

This is no longer valid as we by default have ipv6 enabled on all interfaces.

Allow the ipv6 link-local address as neighbors.

Not sure why do we need LLA as neighbors.

AkhileshSamineni · 2021-08-03T09:49:59Z

Changes to handle the "ipv6_use_link_local_only" option on a interface which is added/deleted based on Global Config or Interface config.

I think, BGP unnumbered use-case is expected to work without this field explicitly configured as ipv6 enabled by default globally on all interfaces i.e LLA should be present., right?
Wondering what's the expectation on the community image for BGP unnumbered functionality to work,
Should we need to disable ipv6 on all interfaces globally first and then enable per interface basis?

Adds/Deletes the RIF for an interface in the absence of IPv6 global address on a interface based on "ipv6_use_link_local_only".

This is no longer valid as we by default have ipv6 enabled on all interfaces.

Allow the ipv6 link-local address as neighbors.

Not sure why do we need LLA as neighbors.

@venkatmahalingam
As per the community new design

Yes, the BGP unnumbered might work without configuring the ipv6 link local on an interface.
Yes, IPv6 LL is enabled by default in the kernel stack and the config command is not enabling/disabling the IPv6 LL in stack. Basically we are not touching that part here.
The global/interface enable config command will create the RIF in the hardware, if there is no ipv6 global address configured on a interface and global/interface disable config command will delete the RIF in the hardware, if there is no ipv6 global address configured on a interface.

anshuv-mfst · 2021-08-03T15:10:34Z

hi @prsunny - could you please review and approve asap, this is needed in 202106 release

prsunny · 2021-08-03T15:52:55Z

hi @prsunny - could you please review and approve asap, this is needed in 202106 release

@anshuv-mfst , waiting on one outstanding comment. @AkhileshSamineni , could you please check the unresolved comments and reply?

…al_mode config

AkhileshSamineni · 2021-08-04T12:41:07Z

hi @prsunny - could you please review and approve asap, this is needed in 202106 release

@anshuv-mfst , waiting on one outstanding comment. @AkhileshSamineni , could you please check the unresolved comments and reply?

@prsunny Added code changes to skip the ipv6 link-local netlink msg in neighsyncd when link-local-mode config is disabled.
Please review the changes.

prsunny · 2021-08-05T14:11:19Z

@venkatmahalingam , can you please sign off?

neighsyncd/neighsync.cpp

As per HLD - sonic-net/SONiC#625 FRR Patches: 0009-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch Files modified : bgpd_network.c and bgpd/bgp_zebra.c Fix for : Link local scope was not set while binding socket with local address causing socket errors for bgp ipv6 link local neighbors. 0010-VRF-interface-lookup-was-still-done-in-the-default-vrf.patch Files modified : staticd/static_zebra.c Fix for : VRF interface lookup was still done in the default-vrf which was causing the interface lookup to fail. Due to this static-route pointing to link-local was not getting installed. 0011-Changes-to-send-ipv6-link-local-address-as-nexthop-to-fpmsyncd.patch Files modified : zebra/zebra_fpm_netlink.c Fix for : Made changes to send ipv6 address as nexthop to fpmsyncd. Depends on: sonic-net/sonic-utilities#1159 sonic-net/sonic-swss#1463 Signed-off-by: Akhilesh Samineni akhilesh.samineni@broadcom.com

* Code changes to support IPv6 Link local enchancements - Changes to handle the "ipv6_use_link_local_only" option on a interface which is added/deleted based on Global Config or Interface config. - Adds/Deletes the RIF for an interface in the absence of IPv6 global address on a interface based on "ipv6_use_link_local_only". - Allow the ipv6 link-local address as neighbors. - Allow adding the IPv6 routes with link-local nexthops. - Skip Ipv4LL neighbor add in Orchagent for RFC5549. Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>

The key used is as read from APPL-DB, hence use it as such to get the value, to help get the interfce name, so it can be used for filtering out.

…thub.com> Date: Thu Aug 5 23:49:44 2021 +0530 Code changes to support IPv6 Link local enhancements (sonic-net#1463)

* Code changes to support IPv6 Link local enchancements - Changes to handle the "ipv6_use_link_local_only" option on a interface which is added/deleted based on Global Config or Interface config. - Adds/Deletes the RIF for an interface in the absence of IPv6 global address on a interface based on "ipv6_use_link_local_only". - Allow the ipv6 link-local address as neighbors. - Allow adding the IPv6 routes with link-local nexthops. - Skip Ipv4LL neighbor add in Orchagent for RFC5549. Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>

puffc · 2024-09-24T01:43:35Z

orchagent/vrforch.cpp

@AkhileshSamineni Could you please share the reason why this part of code was removed? There is a long opened PR #1926 added this code back. Without this changes the BGP unnumbered cannot work properly with VRF.

This was referenced Oct 10, 2020

FRR patches to support IPv6 Link local enhancements. sonic-net/sonic-buildimage#5584

Merged

Global and Interface commands for IPv6 Link local address enhancements sonic-net/sonic-utilities#1159

Merged

AkhileshSamineni force-pushed the ipv6-link-local-changes branch from 8c5b06a to 0baba1c Compare April 5, 2021 17:46

AkhileshSamineni changed the title ~~Code changes to support IPv6 Link local enchancements~~ Code changes to support IPv6 Link local enhancements Apr 5, 2021

lguohan requested a review from zhenggen-xu April 14, 2021 21:18

AkhileshSamineni force-pushed the ipv6-link-local-changes branch from 0fb6a09 to 7053e33 Compare June 7, 2021 08:46

venkatmahalingam reviewed Jun 8, 2021

View reviewed changes

orchagent/vrforch.cpp Outdated Show resolved Hide resolved

venkatmahalingam reviewed Jun 8, 2021

View reviewed changes

fpmsyncd/routesync.cpp Outdated Show resolved Hide resolved

prsunny reviewed Jun 8, 2021

View reviewed changes

neighsyncd/neighsync.cpp Show resolved Hide resolved

venkatmahalingam reviewed Jun 8, 2021

View reviewed changes

orchagent/neighorch.cpp Show resolved Hide resolved

venkatmahalingam previously approved these changes Jun 10, 2021

View reviewed changes

venkatmahalingam approved these changes Jul 31, 2021

View reviewed changes

prsunny self-requested a review July 31, 2021 00:41

prsunny reviewed Jul 31, 2021

View reviewed changes

cfgmgr/intfmgr.cpp Outdated Show resolved Hide resolved

venkatmahalingam suggested changes Jul 31, 2021

View reviewed changes

Addressed minor comment

d774cea

AkhileshSamineni dismissed prsunny’s stale review via d774cea August 2, 2021 12:36

Added changes to skip the link-local neighbors based on ipv6_link_loc…

3e615e2

…al_mode config

prsunny approved these changes Aug 5, 2021

View reviewed changes

venkatmahalingam reviewed Aug 5, 2021

View reviewed changes

neighsyncd/neighsync.cpp Show resolved Hide resolved

venkatmahalingam approved these changes Aug 5, 2021

View reviewed changes

prsunny merged commit 8f7ea14 into sonic-net:master Aug 5, 2021

AkhileshSamineni mentioned this pull request Aug 9, 2021

Added VRF changes for IPv6 link local enhancements #1862

Open

judyjoseph added the Included in 202106 Branch label Aug 10, 2021

puffc reviewed Sep 24, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code changes to support IPv6 Link local enhancements #1463

Code changes to support IPv6 Link local enhancements #1463

AkhileshSamineni commented Oct 10, 2020 •

edited

Loading

AkhileshSamineni commented Oct 22, 2020

batmancn commented Jan 4, 2021

AkhileshSamineni commented Apr 8, 2021

AkhileshSamineni commented Apr 9, 2021

azure-pipelines bot commented Apr 9, 2021

AkhileshSamineni commented Apr 9, 2021

arlakshm commented Apr 12, 2021

azure-pipelines bot commented Apr 12, 2021

AkhileshSamineni commented Apr 15, 2021

AkhileshSamineni commented May 3, 2021

anshuv-mfst commented May 4, 2021

lguohan commented May 4, 2021

prsunny commented May 5, 2021

lgtm-com bot commented Jun 7, 2021

AkhileshSamineni commented Jun 7, 2021

AkhileshSamineni commented Jun 7, 2021

AkhileshSamineni commented Jun 16, 2021

AkhileshSamineni commented Jun 16, 2021

azure-pipelines bot commented Jun 16, 2021

venkatmahalingam left a comment •

edited

Loading

AkhileshSamineni commented Aug 3, 2021

anshuv-mfst commented Aug 3, 2021

prsunny commented Aug 3, 2021

AkhileshSamineni commented Aug 4, 2021

prsunny commented Aug 5, 2021

puffc Sep 24, 2024

Code changes to support IPv6 Link local enhancements #1463

Code changes to support IPv6 Link local enhancements #1463

Conversation

AkhileshSamineni commented Oct 10, 2020 • edited Loading

AkhileshSamineni commented Oct 22, 2020

batmancn commented Jan 4, 2021

AkhileshSamineni commented Apr 8, 2021

AkhileshSamineni commented Apr 9, 2021

azure-pipelines bot commented Apr 9, 2021

AkhileshSamineni commented Apr 9, 2021

arlakshm commented Apr 12, 2021

azure-pipelines bot commented Apr 12, 2021

AkhileshSamineni commented Apr 15, 2021

AkhileshSamineni commented May 3, 2021

anshuv-mfst commented May 4, 2021

lguohan commented May 4, 2021

prsunny commented May 5, 2021

lgtm-com bot commented Jun 7, 2021

AkhileshSamineni commented Jun 7, 2021

AkhileshSamineni commented Jun 7, 2021

AkhileshSamineni commented Jun 16, 2021

AkhileshSamineni commented Jun 16, 2021

azure-pipelines bot commented Jun 16, 2021

venkatmahalingam left a comment • edited Loading

Choose a reason for hiding this comment

AkhileshSamineni commented Aug 3, 2021

anshuv-mfst commented Aug 3, 2021

prsunny commented Aug 3, 2021

AkhileshSamineni commented Aug 4, 2021

prsunny commented Aug 5, 2021

puffc Sep 24, 2024

Choose a reason for hiding this comment

AkhileshSamineni commented Oct 10, 2020 •

edited

Loading

venkatmahalingam left a comment •

edited

Loading