[PINS] Add Bazel support for external projects #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qiluo-msft this is related to #547 |
This was referenced Nov 10, 2021
qiluo-msft
reviewed
Nov 11, 2021
qiluo-msft
reviewed
Nov 12, 2021
qiluo-msft
reviewed
Nov 12, 2021
bocon13
commented
Nov 14, 2021
qiluo-msft
previously approved these changes
Nov 17, 2021
|
Thanks Qi for the approval, Before merging I think we can remove the tests/fakes/BUILD, and tests/mocks/BUILD files. |
Those files are removed. Just need to rebase after #545 is merged. |
qiluo-msft
previously approved these changes
Nov 18, 2021
Bazel build support allows swss-common to used in Bazel projects; this doesn’t change/impact the make-based build system Additionally, - Add Bazel test to CI - Update .gitignore Co-authored-by: Robert J. Halstead rhalstea@google.com Co-authored-by: Runming Wu runmingwu@google.com
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks for the cleanup Brian. Looks like the tests are passing as well. Qi do you mind approving and merging the changes? |
qiluo-msft
approved these changes
Nov 19, 2021
|
Thanks Qi! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel build support allows swss-common to used
in Bazel projects; this doesn’t change/impact the
make-based build system
Submission containing materials of a third party:
Copyright Google LLC; Licensed under Apache 2.0
Co-authored-by: Akarsh Gupta akarshgupta@google.com
Co-authored-by: Ashish Singh ashishksingh@google.com
Co-authored-by: Jay Hu jiarenhu@google.com
Co-authored-by: Manali Kumar manalikumar@google.com
Co-authored-by: Richard Yu richardyu@google.com
Co-authored-by: Robert J. Halstead rhalstea@google.com
Co-authored-by: Runming Wu runmingwu@google.com
Co-authored-by: Srikishen Pondicherry Shanmugam kishanps@google.com
Co-authored-by: Vivek Ramamoorthy vivekmoorthy@google.com
Co-authored-by: Yilan Ji yilanji@google.com
TODO
ETA: this week in a separate PR)