[vslib]: adapt macsec sai 1.7.1 #755
Conversation
Signed-off-by: Ze Gan <ganze718@gmail.com>
|
retest this please |
|
retest this please |
vslib/src/SwitchStateBaseMACsec.cpp
Outdated
|
|
||
| CHECK_STATUS(get(SAI_OBJECT_TYPE_MACSEC_SC, attr->value.oid, static_cast<uint32_t>(attrs.size()), attrs.data())); | ||
|
|
||
| auto flow_id = attrs[0].value.oid; | ||
| auto sci = attrs[1].value.u64; | ||
| std::stringstream sciHexStr; | ||
| macsecAttr.m_encryptionEnable = attrs[2].value.booldata; | ||
| bool is_sak_128_bit = (attrs[3].value.s32 == SAI_MACSEC_CIPHER_SUITE_GCM_AES_128 || attrs[3].value.s32 == SAI_MACSEC_CIPHER_SUITE_GCM_AES_XPN_128) ? true : false; |
There was a problem hiding this comment.
bool is_sak_128_bit = (attrs[3].value.s32 == SAI_MACSEC_CIPHER_SUITE_GCM_AES_128 || attrs[3].value.s32 == SAI_MACSEC_CIPHER_SUITE_GCM_AES_XPN_128)
no need for explicit true/false at the end
There was a problem hiding this comment.
Good suggestion, Fixed it.
|
It would be helpful if you would add unittests recordings for this, and configuration to help prevent such issues in the future. How are you testing this right now ? |
It looks like that other components are causing this failure. |
Yes, There should be some unitests to test this feature. |
|
sure, you can add PR with UT next |
|
retest vs please |
Signed-off-by: Ze Gan <ganze718@gmail.com>
Pterosaur
force-pushed
the
adapt_macsec_sai_171
branch
from
c1eefd0
to
9d117d7
Compare
|
retest vs please |
|
retest this please |
1 similar comment
|
retest this please |
Partial attributes were moved from MACsec SA to MACsec SC, Read these attributes from MACsec SC. Signed-off-by: Ze Gan <ganze718@gmail.com>
Partial attributes were moved from MACsec SA to MACsec SC, Read these attributes from MACsec SC.
Signed-off-by: Ze Gan ganze718@gmail.com