[vslib]Add MACsec Forwarder #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ze Gan <ganze718@gmail.com>
Pterosaur
force-pushed
the
macsec_forwarder
branch
from
4d68205 to
9b12dc1
Compare
kcudnik
reviewed
Nov 19, 2020
vslib/src/MACsecForwarder.cpp
Outdated
|
|
||
| if (write(m_tapfd, buffer, static_cast<int>(size)) < 0) | ||
| { | ||
|
|
kcudnik
reviewed
Nov 19, 2020
vslib/inc/MACsecForwarder.h
Outdated
| int m_tapfd; | ||
| int m_macsecfd; | ||
|
|
||
| const std::string m_macsec_interface_name; |
There was a problem hiding this comment.
try keep naming members consistent like m_macsecInterfaceName, m_runThread, m_exitEvent
please revisit other classes to see convention
Signed-off-by: Ze Gan <ganze718@gmail.com>
kcudnik
approved these changes
Nov 20, 2020
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
MACsec Forwarder is for forwarding plaintext data traffic from MACsec device to tap, Ethernet, device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MACsec Forwarder is for forwarding plaintext data traffic from MACsec device to tap,
Ethernet, device.The design document can be found at https://github.com/Azure/SONiC/blob/88c7ada900051f73a29aaf4a28bcaf5062ae7305/doc/macsec/MACsec_hld.md#345-virtual-macsec-sai
Signed-off-by: Ze Gan ganze718@gmail.com