Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PINS] Build P4RT container for PINS #9083

Merged
merged 8 commits into from
Dec 7, 2021
Merged

[PINS] Build P4RT container for PINS #9083

merged 8 commits into from
Dec 7, 2021

Conversation

bocon13
Copy link
Contributor

@bocon13 bocon13 commented Oct 27, 2021

  • Add INCLUDE_PINS to config to enable/disable container
  • Add Docker files and supporting resources
  • Add sonic-pins submodule and associated make files

Submission containing materials of a third party:
Copyright Google LLC; Licensed under Apache 2.0

Co-authored-by: Runming Wu runmingwu@google.com
Co-authored-by: Robert J. Halstead rhalstea@google.com
Co-authored-by: Srikishen Pondicherry Shanmugam kishanps@google.com
Co-authored-by: Brian O'Connor bocon@opennetworking.org

Why I did it

Adds P4RT container to SONiC for PINS

The P4RT app is covered by this HLD:
https://github.com/pins/SONiC/blob/master/doc/pins/p4rt_app_hld.md

How I did it

Followed the pattern and templates used for other SONiC applications

How to verify it

Build SONiC with INCLUDE_P4RT set to "y".
Verify that the resulting build has a container called "p4rt" running.
You can verify that the service is up by running the following command on the SONiC switch:

sudo netstat -lpnt | grep p4rt

You should see the service listening on TCP port 9559.

Which release branch to backport (provide reason below if selected)

None

Description for the changelog

Build P4RT container for PINS

This was referenced Oct 27, 2021
Open
Open
@bocon13
Copy link
Contributor Author

bocon13 commented Oct 27, 2021

cc: @rhalstea

rhalstea
rhalstea reviewed Oct 28, 2021
View reviewed changes
src/sonic-p4rt/Makefile Outdated Show resolved Hide resolved
@donNewtonAlpha donNewtonAlpha force-pushed the pins/p4rt-app branch 2 times, most recently from 62af37f to 33042a6 Compare October 30, 2021 03:22
@bocon13
Copy link
Contributor Author

bocon13 commented Nov 18, 2021

@lguohan please take a look at the new Dockerfiles and make files for the P4RT container.

We will update the submodules after all of the dependencies are merged.

@bocon13 bocon13 force-pushed the pins/p4rt-app branch 2 times, most recently from 0f1712c to bfc824f Compare November 22, 2021 23:57
@lguohan
Copy link
Collaborator

lguohan commented Nov 23, 2021

there are quite a few docker-slave build failures, can you check?

@bocon13
Copy link
Contributor Author

bocon13 commented Nov 23, 2021

there are quite a few docker-slave build failures, can you check?

@lguohan, this issue is that pre-built Bazel binaries are not available for armhf. We will check to see if they can be published upstream. Otherwise, we can build them ourselves and work with you to put them somewhere accessible.

For now, I have disabled P4RT for armhf targets and put a TODO to fix this issue.

Tests are re-running now. Thanks!

@bocon13 bocon13 force-pushed the pins/p4rt-app branch 2 times, most recently from a60a692 to 02b459f Compare November 23, 2021 17:52
@bocon13
Copy link
Contributor Author

bocon13 commented Nov 23, 2021

/azpw run Azure.docker-slave-bullseye

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.docker-slave-bullseye

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bocon13
Copy link
Contributor Author

bocon13 commented Nov 23, 2021

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bocon13
Copy link
Contributor Author

bocon13 commented Nov 23, 2021

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@rhalstea
Copy link
Contributor

rhalstea commented Dec 2, 2021

Thanks for the review @prsunny @qiluo-msft ,

PTAL. I pushed an update addressing the comments.

@bocon13
Copy link
Contributor Author

bocon13 commented Dec 6, 2021

/azpw run Azure.docker-slave-bullseye

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.docker-slave-bullseye

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

PINS Working Group and others added 6 commits December 6, 2021 09:04
@bocon13
[PINS] Build P4RT container for PINS
6141e4e 
- Add INCLUDE_PINS to config to enable/disable container
- Add Docker files and supporting resources
- Add sonic-pins submodule and associated make files

Submission containing materials of a third party:
    Copyright Google LLC; Licensed under Apache 2.0

Co-authored-by: Runming Wu <runmingwu@google.com>
Co-authored-by: Robert J. Halstead <rhalstea@google.com>
Co-authored-by: Srikishen Pondicherry Shanmugam <kishanps@google.com>
Co-authored-by: Brian O'Connor <bocon@opennetworking.org>

Signed-off-by: Brian O'Connor <bocon@opennetworking.org>
@bocon13 @prsunny
Update rules/config to set INCLUDE_P4RT to n
4f11328 
Co-authored-by: Prince Sunny <prince.sunny@microsoft.com>
@rhalstea @bocon13
[PINS] Cleanup sonic-pins build files.
364c1fb
@bocon13
Address PR comment on sync_mode
c8d3d71
@bocon13
Address comment: remove one pushd for P4RT Makefile
57a3043
@bocon13
Address comment: use python-is-python3 package for bullseye builder
ed9d8e8
@bocon13
Copy link
Contributor Author

bocon13 commented Dec 6, 2021 •
edited
Loading

Issue installing python-is-python3 on Azure Pipelines

Update: Nevermind, it was a typo in the package name. Fixed and re-running tests.

@bocon13
Copy link
Contributor Author

bocon13 commented Dec 6, 2021

/azpw run Azure.docker-slave-bullseye

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.docker-slave-bullseye

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@donNewtonAlpha
Copy link
Contributor

@qiluo-msft All required tests have passed can we get this merged now?

@qiluo-msft qiluo-msft merged commit 46bcda3 into sonic-net:master Dec 7, 2021
@bocon13 bocon13 deleted the pins/p4rt-app branch December 7, 2021 19:14
@lguohan lguohan added the Request for 202111 Branch For PRs being requested for 202111 branch label Dec 7, 2021
abdosi pushed a commit that referenced this pull request Dec 8, 2021
@bocon13 @abdosi
[PINS] Build P4RT container for PINS (#9083)
6bffcb9 
- Add INCLUDE_PINS to config to enable/disable container
- Add Docker files and supporting resources
- Add sonic-pins submodule and associated make files

Submission containing materials of a third party:
    Copyright Google LLC; Licensed under Apache 2.0

#### Why I did it

Adds P4RT container to SONiC for PINS

The P4RT app is covered by this HLD:
https://github.com/pins/SONiC/blob/master/doc/pins/p4rt_app_hld.md

#### How I did it

Followed the pattern and templates used for other SONiC applications

#### How to verify it

Build SONiC with INCLUDE_P4RT set to "y".
Verify that the resulting build has a container called "p4rt" running.
You can verify that the service is up by running the following command on the SONiC switch:
```bash
sudo netstat -lpnt | grep p4rt
```
You should see the service listening on TCP port 9559.

#### Which release branch to backport (provide reason below if selected)

None

#### Description for the changelog

Build P4RT container for PINS
@rhalstea rhalstea mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mint570 mint570 mint570 left review comments

@rlhui rlhui rlhui left review comments

@rhalstea rhalstea rhalstea left review comments

@prsunny prsunny prsunny approved these changes

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

@xumia xumia Awaiting requested review from xumia xumia is a code owner

Assignees
No one assigned
Labels
Included in 202111 Branch Request for 202111 Branch For PRs being requested for 202111 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.