[PINS] Add APPL_STATE_DB and response path log rotation #9082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @mint570 |
mint570
reviewed
Oct 27, 2021
| @@ -32,6 +32,7 @@ | |||
| /var/log/frr/zebra.log | |||
| /var/log/swss/sairedis*.rec | |||
| /var/log/swss/swss*.rec | |||
| /var/log/swss/responsepublisher.rec | |||
There was a problem hiding this comment.
This is APPL STATE DB record. We haven't look at multi asic support yet.
|
@prsunny please take look |
donNewtonAlpha
force-pushed
the
pins/appl-state-db
branch
2 times, most recently
from
96cddbc
to
3be0fd4
Compare
bocon13
force-pushed
the
pins/appl-state-db
branch
from
af53b23
to
eca314b
Compare
bocon13
force-pushed
the
pins/appl-state-db
branch
from
eca314b
to
91a8432
Compare
|
Rebased to latest master |
prsunny
previously approved these changes
Nov 23, 2021
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Commenter does not have sufficient privileges for PR 9082 in repo Azure/sonic-buildimage |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- Add APPL_STATE_DB to database_config.json
- Clear APPL_STATE_DB during SwSS container restarts
- Add response path log file to logrotate config:
responsepublisher.rec
Submission containing materials of a third party:
Copyright Google LLC; Licensed under Apache 2.0
Co-authored-by: Mike Attig <mikeattig@google.com>
Co-authored-by: Runming Wu <runmingwu@google.com>
Co-authored-by: Akarsh Gupta <akarshgupta@google.com>
Signed-off-by: Brian O'Connor <bocon@opennetworking.org>
mint570
force-pushed
the
pins/appl-state-db
branch
from
91a8432
to
1baca65
Compare
|
@prsunny, the checks are passing now. Can you reapprove and merge? Thanks! |
prsunny
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
responsepublisher.rec
Submission containing materials of a third party:
Copyright Google LLC; Licensed under Apache 2.0
Co-authored-by: Mike Attig mikeattig@google.com
Co-authored-by: Runming Wu runmingwu@google.com
Co-authored-by: Akarsh Gupta akarshgupta@google.com
Why I did it
Adds support for APPL_STATE_DB and response path required for PINS.
Described in this HLD:
https://github.com/pins/SONiC/blob/master/doc/pins/appl_state_db_response_path_hld.md
How to verify it
Any build should do the trick, then verify that the APPL_STATE_DB is empty after restarting swss.
Which release branch to backport (provide reason below if selected)
None
Description for the changelog
Add APPL_STATE_DB and response path log rotation