[sonic-slave]: Add gmock for sonic-swss-common tests #8950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lguohan the 2 tests that are failing are unlikely caused by this change. Is there anyway to push this forward? It will ultimately block a PR that will go into sonic-swss-common for the PINs integration. |
bocon13
previously approved these changes
Oct 22, 2021
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8950 in repo Azure/sonic-buildimage |
donNewtonAlpha
force-pushed
the
add-gtest
branch
from
7dbf672 to
895a55e
Compare
yxieca
previously approved these changes
Oct 27, 2021
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Signed-off-by: Don Newton <don@opennetworking.org>
donNewtonAlpha
force-pushed
the
add-gtest
branch
from
895a55e to
a4fb693
Compare
|
Rebased to latest master to retrigger test run |
lguohan
approved these changes
Oct 28, 2021
lguohan
changed the title
|
@lguohan @yxieca Please help us backport this to 202106 and 202012. Currently all active branches share the same Docker tag: Longer term, we should fix this, but for now, this is causing trouble for PINS. Specifically, if the 202012 container is the most recently pushed, we are missing gmock. There should be no harm/risk associated with backporting this change. Thanks! |
xumia
pushed a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Oct 20, 2022
Sonic-swss-common requires gmock for staged unit tests Signed-off-by: Don Newton <don@opennetworking.org>
7 tasks
xumia
added a commit
that referenced
this pull request
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Don Newton don@opennetworking.org
Why I did it
Sonic-swss-common requires gmock for staged unit tests
How I did it
Installed dependency in sonic-buster-build docker file
How to verify it
rebuild the build container