Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trap flow counter support #8940

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

Junchao-Mellanox
Copy link
Collaborator

Why I did it

Add trap flow counter support

How I did it

Enable trap flow rate calculation

How to verify it

Manual test/VS test/sonic-mgmt test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@Junchao-Mellanox
Copy link
Collaborator Author

Hi @lguohan, could you please suggest a reviewer?

@Junchao-Mellanox
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@Junchao-Mellanox
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@Junchao-Mellanox
Copy link
Collaborator Author

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8940 in repo Azure/sonic-buildimage

keboliu
keboliu previously approved these changes Nov 17, 2021
@keboliu keboliu requested a review from prsunny November 17, 2021 01:52
prsunny
prsunny previously approved these changes Nov 23, 2021
Copy link
Contributor

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, can yang subgroup review the Yang file change?

@prsunny prsunny merged commit 554b04f into sonic-net:master Nov 24, 2021
@Junchao-Mellanox Junchao-Mellanox added the Request for 202111 Branch For PRs being requested for 202111 branch label Dec 8, 2021
@abdosi abdosi removed the Request for 202111 Branch For PRs being requested for 202111 branch label Dec 8, 2021
@Junchao-Mellanox Junchao-Mellanox deleted the flow-counter branch December 9, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants