VxLAN Tunnel Counters and Rates implementation #8369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 459d3d1.
…onic-net#7281)"" This reverts commit f0b2122.
This reverts commit 9c172a5.
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
srj102
previously approved these changes
Oct 22, 2021
prsunny
reviewed
Oct 29, 2021
| @@ -43,6 +45,7 @@ def enable_counters(): | |||
| enable_counter_group(db, 'QUEUE_WATERMARK') | |||
| enable_counter_group(db, 'BUFFER_POOL_WATERMARK') | |||
| enable_counter_group(db, 'PORT_BUFFER_DROP') | |||
| enable_counter_group(db, 'TUNNEL') | |||
There was a problem hiding this comment.
Lets disable the counter by default and enable based on need
| @@ -29,6 +29,8 @@ def enable_rates(): | |||
| counters_db.set('COUNTERS_DB', 'RATES:PORT', 'PORT_ALPHA', DEFAULT_ALPHA) | |||
| counters_db.set('COUNTERS_DB', 'RATES:RIF', 'RIF_SMOOTH_INTERVAL', DEFAULT_SMOOTH_INTERVAL) | |||
| counters_db.set('COUNTERS_DB', 'RATES:RIF', 'RIF_ALPHA', DEFAULT_ALPHA) | |||
| counters_db.set('COUNTERS_DB', 'RATES:TUNNEL', 'TUNNEL_SMOOTH_INTERVAL', DEFAULT_SMOOTH_INTERVAL) | |||
| counters_db.set('COUNTERS_DB', 'RATES:TUNNEL', 'TUNNEL_ALPHA', DEFAULT_ALPHA) | |||
There was a problem hiding this comment.
What is the interval value?
There was a problem hiding this comment.
Smooth interval is used in rate calculate where the traffic within this time limit are given higher weightage for rate calculation (for e.g. in last 10 sec over the traffic received prior to it) . https://github.com/Azure/SONiC/blob/master/doc/rates-and-utilization/Rates_and_utilization_HLD.md
prsunny
approved these changes
Nov 1, 2021
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Jun 30, 2022
* Enable flex counters for Vxlan tunnel
7 tasks
prsunny
pushed a commit
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To Enable tunnel counters
How I did it
Enabling flex counters
How to verify it
Using show command and unit tests
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)